[coreboot-gerrit] New patch to review for coreboot: cbfstool: Silence LZ4 -Wsign-compare warnings
Julius Werner (jwerner@chromium.org)
gerrit at coreboot.org
Tue Feb 23 00:33:04 CET 2016
Julius Werner (jwerner at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13769
-gerrit
commit 042701b613183c3b77c2a880a4dc2ecc1558b22e
Author: Julius Werner <jwerner at chromium.org>
Date: Mon Feb 22 15:30:37 2016 -0800
cbfstool: Silence LZ4 -Wsign-compare warnings
It seems that the exact behavior of -Wsign-compare changes between GCC
versions... some of them like the commonlib/lz4_wrapper.c code, and some
don't. Since we don't have a well-defined HOSTCC toolchain this slipped
through pre-commit testing. Explicitly silence the warning to ensure
cbfstool still builds on all systems.
Change-Id: I43f951301d3f14ce34dadbe58e885b82d21d6353
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
util/cbfstool/Makefile.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc
index f480616..8824ad0 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.inc
@@ -150,6 +150,7 @@ $(objutil)/cbfstool/cbfs.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual
$(objutil)/cbfstool/mem_pool.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual
# Tolerate lz4 warnings
$(objutil)/cbfstool/lz4.o: TOOLCFLAGS += -Wno-missing-prototypes
+$(objutil)/cbfstool/lz4_wrapper.o: TOOLCFLAGS += -Wno-sign-compare
$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_parser.h
$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_scanner.h
More information about the coreboot-gerrit
mailing list