[coreboot-gerrit] New patch to review for coreboot: Revert "cbfstool: Silence LZ4 -Wsign-compare warnings"
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Tue Feb 23 19:21:38 CET 2016
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13772
-gerrit
commit 7110e09eb1185622ed6162213d8827e4d65159a6
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Tue Feb 23 19:19:20 2016 +0100
Revert "cbfstool: Silence LZ4 -Wsign-compare warnings"
This reverts commit 17cb0370a70ccfc2301b7974bf38d44c7271afea.
It’s the wrong thing to do, to just disable the warning. The code is
fixed for 32-bit user space now in Change-Id
I85bee25a69c432ef8bb934add7fd2e2e31f03662 (commonlib/lz4_wrapper: Use
correct casts to ensure valid calculations), so enable the warning
again.
Change-Id: I6d1c62c7b4875da8053c25e640c03cedf0ff2916
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
util/cbfstool/Makefile.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc
index 8824ad0..f480616 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.inc
@@ -150,7 +150,6 @@ $(objutil)/cbfstool/cbfs.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual
$(objutil)/cbfstool/mem_pool.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual
# Tolerate lz4 warnings
$(objutil)/cbfstool/lz4.o: TOOLCFLAGS += -Wno-missing-prototypes
-$(objutil)/cbfstool/lz4_wrapper.o: TOOLCFLAGS += -Wno-sign-compare
$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_parser.h
$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_scanner.h
More information about the coreboot-gerrit
mailing list