[coreboot-gerrit] New patch to review for coreboot: coreinfo: quote $(AS) and $(CC) in $(LPAS) and $(LPCC)
Iru Cai (mytbk920423@gmail.com)
gerrit at coreboot.org
Sat Feb 27 04:56:21 CET 2016
Iru Cai (mytbk920423 at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13845
-gerrit
commit 91d0f64c105a7a39aa82a7f3eb33ce20570909fe
Author: Iru Cai <mytbk920423 at gmail.com>
Date: Sat Feb 27 11:47:06 2016 +0800
coreinfo: quote $(AS) and $(CC) in $(LPAS) and $(LPCC)
without this change it'll get a build error with crossgcc-x64
because $(AS) is "util/crossgcc/xgcc/bin/x86_64-elf-as --32",
and running $(LPAS) (i.e. AS=$(AS) lpas) will run "--32" instead of
"x86_64-elf-as".
Change-Id: I95e5630cb1d4f1ce81a8ca8a7bf338450b325f02
Signed-off-by: Iru Cai <mytbk920423 at gmail.com>
---
payloads/coreinfo/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile
index a3a02c2..c9f5c10 100644
--- a/payloads/coreinfo/Makefile
+++ b/payloads/coreinfo/Makefile
@@ -78,8 +78,8 @@ CC := $(CC_$(ARCH-y))
AS := $(AS_$(ARCH-y))
OBJCOPY := $(OBJCOPY_$(ARCH-y))
-LPCC := CC=$(CC) $(LIBPAYLOAD_DIR)/libpayload/bin/lpgcc
-LPAS := AS=$(AS) $(LIBPAYLOAD_DIR)/libpayload/bin/lpas
+LPCC := CC="$(CC)" $(LIBPAYLOAD_DIR)/libpayload/bin/lpgcc
+LPAS := AS="$(AS)" $(LIBPAYLOAD_DIR)/libpayload/bin/lpas
CFLAGS += -Wall -Werror -Os -fno-builtin $(CFLAGS_$(ARCH-y)) $(INCLUDES)
More information about the coreboot-gerrit
mailing list