Tyan S4880

Eric W. Biederman ebiederman at lnxi.com
Tue Dec 2 01:19:01 CET 2003


YhLu <YhLu at tyan.com> writes:

> Ron,
> 
> Please check in the Tyan s2850/2880/2881/2882/4880 updates into the CVS
> Tree.
> 
> 1. northbridge/amd/amdk8/raminit.h: change uint8_t to uint16_t

This is quite reasonable.

> 2. southbridge/amd/amd8111/amd8111_early_smbus.c: update smbus_write_byte
> 3. southbridge/amd/amd8131/amd8131_bridge.c: update ioapic_anable to enable
> PCI-X MASTER Mode.

Why is this necessary?  Previously it has been the policy to not set
the master enables any more than is necessary for proper operation
of the devices.  Unless I am mistaken not setting the master enables is
very much in spec for pci devices.

> 4. other in /src/mainboard/tyan/ and /targets/tyan
> 
> Stefan,
> With update 1 and 2, you can get ride of FAKE_SPD_ROM. You need to change
> some lines in auto.c for quartet. 1. I2C HUB address: 0x30 --> 0x18, 2.
> RC0-> (1<<1)<<8, RC1-> (1<<2)<<8, RC2-> (1<<3)<<8, RC3-> (1<<4)<<8.

Looking at the diffstat output you also touched the quartet/Config.lb and removed
the FAKE_SPD define.  Has this been tested?

There is a context diff included in tyan/s2881/lyh.txt that does not look like
it needs to be there.

And of course there were all kinds of binary roms that the diff did not include.

Eric



More information about the coreboot mailing list