Patch for V2 new config
Greg Watson
gwatson at lanl.gov
Wed Oct 1 11:01:01 CEST 2003
If my understanding is correct, you want to have an option value that
has a mainboard specific default value, but that can be overridden in
the target configuration file?
If this is the case, then my preference would be to do something like
the following in the mainboard file:
if ~ ROM_IMAGE_SIZE
option ROM_IMAGE_SIZE = 65536
end
where the '~' operator means "hasn't been set".
It seems to me this would be clearer than changing a default value,
possibly after the value has already been set.
Greg
At 3:44 PM +0100 1/10/03, Mark Wilkinson wrote:
>Hi Ron,
> I started looking at building the Via/Epia with the v2, and
>noticed that your
>last snapshot said that the mainboard Config.lb should set the ROM_SIZE to
>265K.
>
>Here's a little patch that lets the config python use
>'default OPTION value' tag in the Mainboard Config.lb overriding the value set
>in config/Optins.lb (which has ROM_SIZE set to NONE)
>
>or should the command be 'default OPTION=<value>' in which case, alter the
>line for 'rule default<<C>>: ...' to read
> rule default<<C>>: DEFAULT ID EQ value {{ if(C): mbdefault(ID,value) }}
>
>Regards
>Mark Wilkinson.
>
>PS. Hope to burn a V2 epia bios tomorrow morning and test !!
>Attachment converted: Macintosh HD:config.patch (TEXT/ttxt) (002EE9D4)
More information about the coreboot
mailing list