pci_scan_get_dev() in pci_scan_bus()

Li-Ta Lo ollie at lanl.gov
Tue Mar 9 12:00:01 CET 2004


On Mon, 2004-03-08 at 21:45, Eric W. Biederman wrote:
> Li-Ta Lo <ollie at lanl.gov> writes:
> 
> > On Fri, 2004-03-05 at 16:52, Eric W. Biederman wrote:
> > > Li-Ta Lo <ollie at lanl.gov> writes:
> > > 
> > > > What happen if a device is listed as a static device in the
> > > > config file but does not actually exist in the physical system ?
> > > 
> > > The device won't go away.  But it can legitimately show up as
> > > a disabled device in the device tree.
> > > 
> > > I'm not certain when you would want to report a device statically
> > > that may or may not be there.
> > > 
> > 
> > That happens for the processor. We list two cpus in current k8 mainboard
> > config files. But if there is only one cpu install, we will have a lot
> > of "absent" devices.
> 
> Well we will have an absent bus.  But everything should work properly.
> It would not hurt to test it and make certain though.  It works in principle,
> and should be easy to fix if the practice does not match.
> 

On thing I am worry about is there are some code calling the "device 
driver" no matter if the device really exist. One example is the
pci_scan_bus() which calls the enable_dev() when it found the device
on the list of "static->dynamic" devices. What if the enable_dev() does
something nasty and lock the machine ?

Ollie





More information about the coreboot mailing list