Removing device driver code in mainboard.c for Tyan boards?
YhLu at tyan.com
Fri Nov 5 19:06:01 CET 2004
Is more understanding even for one MC MB.
Without " config chip.h"
The corresponding device chip_ops field will be 0, and not to some ......ops
3. another is
if not define " uses CONFIG_CHIP_NAME" in MB Option.lb
and use "if CONFIG_CHIP_NAME config chip.h end
the config.g will be report CONFIG_CHIP_NAME is not defined, just
some other strang reporting.
From: ebiederman at lnxi.com [mailto:ebiederman at lnxi.com]
Sent: Friday, November 05, 2004 5:13 PM
Cc: 'Ronald G. Minnich'; 'Li-Ta Lo'; 'LinuxBIOS'
Subject: Re: Removing device driver code in mainboard.c for Tyan boards?
YhLu <YhLu at tyan.com> writes:
> I changed e7501 to use root_complex too.
Could we please reserve this construct for chipsets
with multiple northbridges?
I think it is just going to be extra noise on a
simple chipset like the e7501.
And since the e7501 is an example to a certain extent having it
doing extra work be confusing and a pain.
> If the chip_ops has no .name, then should use
> if CONFIG_CHIP_NAME
> config chip.h
> also .c include that chip_ops
> #if CONFIG_CHIP_NAME
> ...chip_ops defininition
> Such as norththbridge, socket, mainboard(root).
They can. But I am about to suggest simply removing the config
directive, and assuming the ``config chip.h'' is always given. The
overhead is almost zero for a zero filled structure. And always
requiring a chip.h would tend to simply the process of writing code
for a new chip.
More information about the coreboot