ppc targets
Stefan Reinauer
stepan at openbios.org
Fri Nov 12 16:13:00 CET 2004
Ron,
I'll give a quick comment. Some patches are fixing smaller issues
where prototypes and their functions drifted because a prototype was
changed due to x86 merger but the ppc function was not adopted or
similar. Others add missing includes. With these patches I get all PPC
ports built up to the point of the missing mem_range structure which i
did not attempt to fix.
> --- src/arch/ppc/boot/linuxbios_table.c 27 Oct 2004 08:53:35 -0000 1.7
> +++ src/arch/ppc/boot/linuxbios_table.c 11 Nov 2004 15:39:34 -0000
> @@ -129,7 +129,7 @@
> void lb_memory_range(struct lb_memory *mem,
> - uint32_t type, uint64_t start, uint64_t size)
> + uint32_t type, unsigned long start, unsigned long size)
> {
The prototype in linuxbios_table.h uses ulongs too. This would be the
same on ppc64 platforms, but on ppc ulong is just 32bit (pointer size)
> diff -u -r1.1 linuxbios_table.h
> --- src/arch/ppc/boot/linuxbios_table.h 13 Jun 2003 22:07:51 -0000 1.1
> +++ src/arch/ppc/boot/linuxbios_table.h 11 Nov 2004 15:39:34 -0000
> @@ -7,8 +7,6 @@
> unsigned long write_linuxbios_table(
> - unsigned long *processor_map,
> - struct mem_range *ram,
> unsigned long low_table_start, unsigned long low_table_end,
> unsigned long rom_table_start, unsigned long rom_table_end);
These are unused and unimplemented in the actual function.
> --- src/arch/ppc/lib/cpuid.c 27 Oct 2004 08:53:35 -0000 1.5
> +++ src/arch/ppc/lib/cpuid.c 11 Nov 2004 15:39:34 -0000
> @@ -3,6 +3,7 @@
> #include "ppcreg.h"
> +#include <device/device.h>
> #include <console/console.h>
missing include
> --- src/include/cpu/cpu.h 16 Oct 2004 06:20:04 -0000 1.4
> +++ src/include/cpu/cpu.h 11 Nov 2004 15:39:34 -0000
> @@ -2,7 +2,7 @@
> #define CPU_CPU_H
>
> struct device;
> -#include <arch/cpu.h>
> +// #include <arch/cpu.h>
>
> void cpu_initialize(void);
> void initialize_cpus(struct bus *cpu_bus);
The file was not there on PPC. I created it now and reversed above
patch.
Stefan
More information about the coreboot
mailing list