Eric W. Biederman
ebiederman at lnxi.com
Mon Nov 15 10:16:01 CET 2004
Stefan Reinauer <stepan at openbios.org> writes:
> * Eric Biederman <ebiederm at users.sourceforge.net> [041115 11:46]:
> > Modified Files:
> > coherent_ht.c
> > Log Message:
> > - optimize_link_read_pointers compiles now on the solo so don't disable it.
> The problem was actually not htat it did not compile, but that it made
> linuxbios hang on the hardware. Did you verify that it does not do this
> anymore with optimize_link_read_pointers()?
> I cannot verify this since I don't have access to test hardware anymore.
The comment about why it was disabled was significantly ambiguous that
it could be either a compile problem or a hang problem. And potentially
it could have been both.
According to cvs I committed that code initially and it shows up in my
tree several weeks before it shows up in the public freebios2 tree so
I am inclined to trust my memory.
However there are 2 significant checks we can perform.
- Did the original version compile?
- Does this work on the tyan/s2850
I just checked out the original version and it does not compile it
runs out of registers.
So unless YhLu has problems on the s2850 or we can dig something up in
the mailing list archives I am fairly certain that this change is ok.
More information about the coreboot