[LinuxBIOS] r2373 - trunk/LinuxBIOSv2/util/newconfig

svn at openbios.org svn at openbios.org
Fri Aug 11 08:49:40 CEST 2006

Author: rsmith
Date: 2006-08-11 08:49:39 +0200 (Fri, 11 Aug 2006)
New Revision: 2373

- fix dependency rule for Makefile and Makefile.settings

The make dependency rule for Makefile and Makefile.settings was completely broken.  No way it ever worked.
OLPC buildrom flushed out this issue.

If you updated the Config.lb file in your target/<mfg>/<mainboard> directory and then switched to 
target/<mfg>/<mainboard>/<target> and ran 'make' you would get a permission denied error due to the 
make file trying to run 'config.py' directly rather than 'python config.py'
We never saw this because we always run target/buildtarget <target> and that sets up everything

Modified: trunk/LinuxBIOSv2/util/newconfig/config.g
--- trunk/LinuxBIOSv2/util/newconfig/config.g	2006-08-11 00:08:37 UTC (rev 2372)
+++ trunk/LinuxBIOSv2/util/newconfig/config.g	2006-08-11 06:49:39 UTC (rev 2373)
@@ -1933,8 +1933,8 @@
 def writemakefilefooter(file, fname):
 	file.write("\n\n%s: %s %s\n"
 		% (os.path.basename(fname), os.path.abspath(sys.argv[0]), top_config_file))
-	file.write("\t(cd %s ; %s %s %s)\n\n"
-		% (os.getcwd(), sys.argv[0], sys.argv[1], sys.argv[2]))
+	file.write("\t(cd %s ; export PYTHONPATH=%s/util/newconfig ; python %s %s %s)\n\n"
+		% (os.getcwd(), treetop, sys.argv[0], sys.argv[1], sys.argv[2]))
 def writemakefilesettings(path):
 	""" Write Makefile.settings to seperate the settings

More information about the coreboot mailing list