[LinuxBIOS] #70: fix util/getpir so that the output will compile

Tom Sylla tsylla at gmail.com
Tue Dec 19 23:55:42 CET 2006


Why is that not in the README then? Maybe it is somehow clear to all
you LBers, but for someone new, the documentation is *extremely*
misleading. The tool itself says:

printf("Done, you can move the file to the LinuxBios tree now.\n");

That implies that it will just work. The resulting source also
admonishes the user:

"/* This file was generated by getpir.c, do not modify! \n   (but if
you do, please run checkpir on it to verify)\n",

which even implies more that it should "just work".

If the few sentences you wrote, and those of Stefan were in the
README, much less confusion would exist.

On 12/19/06, Li-Ta Lo <ollie at lanl.gov> wrote:
> On Tue, 2006-12-19 at 17:17 -0500, Jon Dufresne wrote:
> > In that case this utility program is very misleading, at least to me.
> > Perhaps a large comment should be added to the .c file that either
> > gives a warning that it is incomplete or tips on what to add.
> >
> There is no way for the utility to know if it is generating something
> useful. There is zero intelligence in the utility and it just dumps
> whatever it is in the memory in a human and compiler readable form.
> This is a totally use at your own risk thing.
> Ollie
> --
> linuxbios mailing list
> linuxbios at linuxbios.org
> http://www.openbios.org/mailman/listinfo/linuxbios

More information about the coreboot mailing list