[LinuxBIOS] r2489 - trunk/LinuxBIOSv2/util/flashrom

Stefan Reinauer stepan at coresystems.de
Sun Nov 5 21:34:05 CET 2006

* Segher Boessenkool <segher at kernel.crashing.org> [061105 20:49]:
> Trivial in this case, but in general: can we please add
> the name or document number (not just the URL) for datasheets
> and other documentation?  Vendors just _love_ to rearrange
> their websites (and some pull their old docs altogether);
> if we have the name/number (or even just the filename of
> the pdf) at least there's a chance to google for it again
> (either on the vendor's site or on some archive).
good hint. I added this to the devel guidelines.

> >+           Set bit 2: BIOSCS# Write Protect Enable (1=enable,  
> >0=disable). */
> The bit is misnamed in the datasheet: it's the "write enable"
> bit, not the "write protect enable" (which would be "write disable").

nitpicking award 2006 ;-)

> >+		printf("tried to set 0x%x to 0x%x on %s failed (WARNING 
> >ONLY) \n", xbcs, new, name);
> Warning only?  It's pretty damn fatal :-)  Or does this mean
> "trying to continue anyway" (which might not be such a great
> plan for a utility that can brick your system)?

it actually is. For the Via Epia you have to continue, because this 
test basically fails every second time. But flashing works like a charme.

It's not that bad either, because if it really fails, you fail to write
to flash. In which case you dont brick your system.

> Would be nice if this message could be made a bit less cryptic,
> for example, "WARNING: failed setting %s register %#x to %#x\n".
> Yes I realise this is probably copied all over the place ;-)

Good idea. Or should we just drop this message all together? Or make it 
printf_debug? If its an error, writing will fail later on anyways.

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/

More information about the coreboot mailing list