[LinuxBIOS] #31: Do proper checking for flash erase for SST FWH parts

Segher Boessenkool segher at kernel.crashing.org
Sun Nov 5 21:40:04 CET 2006

>  Instead of checking the first byte only, the whole part is checked  
> now.
>  This will detect any improper erase. The patch removes a FIXME. :-)

... and adds one, heh :-)

>  Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

The patch never made it to the mailing list.  To review the
patch I now have to:

1) Click the link in the trac mail;
2) Find the correct patch in the list, click it;
3) Scroll all the way to the bottom, click "download original format";
4) Remember the file name (and see that it has a MIME type of;
    "text/x-diff", whatever that is);
5) Open the file in some editor;
6) Copy all text;
7) Press "reply" somewhere in the trac page;
8) Paste that patch;
9) Fixup all mangling (insofar as possible) that the HTML textfield
    did to the whitespace etc.;
10) Type my comments;
11) Click "submit";
12) See my mail on the mailinglist and discover it doesn't do
     mail threading;
13) Clean up the garbage file.

While with reviewing a patch on a mailing list I do

1) Hit the "reply to all" button (so that all interested people
    will see my comments first thing!);
2) Type my comments.

This isn't working too well, even for just *reading* submitted
patches I'll have to do steps 1) and 2) now, and close the
browser window and return to the mail window; this is a non-linear
workflow, while with mail I just go scroll-scroll-scroll-scroll.

LinuxBIOS is really low-volume but it already almost takes me longer
to keep up with the patch flow than it takes for Linux.

Don't take this as a flame, I just need a working working  
environment :-)


More information about the coreboot mailing list