[LinuxBIOS] [PATCH] Add includes to it8712f/superio.c

Uwe Hermann uwe at hermann-uwe.de
Sun Nov 26 18:20:43 CET 2006


sorry for the delay.

On Mon, Nov 20, 2006 at 05:17:25PM -0500, Jon Dufresne wrote:
> Added two includes to it8712f/superio.c, the file will not compile without 
> them
> Signed-off-by: Jon Dufresne <jon.dufresne at gmail.com>
> ---

> Index: src/superio/ite/it8712f/superio.c
> ===================================================================
> --- src/superio/ite/it8712f/superio.c	(revision 2498)
> +++ src/superio/ite/it8712f/superio.c	(working copy)
> @@ -18,6 +18,8 @@
>   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
>   */
> +#include <device/device.h>
> +#include <device/pnp.h>
>  #include <uart8250.h>
>  #include <pc80/keyboard.h>
>  #include "chip.h"

All other ITE Super I/Os will have the same problem, I guess. I probably
didn't notice this as the #includes are drawn in in some other file,
too, on the mainboard code I used.

Can you crate a patch which fixes all of the ITEs, adding all required
#includes to all files (mostly superio.c and chip.h)?

Please also note, that I didn't test any of the ITE chips other than
IT8671F, so they may or may not work. If you could test serial output, that
would be very nice. Anything other than serial output (floppy, keyboard,
whatever) I haven't tested _at all_, and partly there's not even any
code written for that, yet (but it's not too hard)...

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20061126/f5e02e21/attachment.sig>

More information about the coreboot mailing list