[LinuxBIOS] FW: rev F support code

[Uwe Hermann]

Hi,

On Wed, Oct 04, 2006 at 07:29:40PM -0700, Lu, Yinghai wrote:
> How about
> 
> /*
>  * Copyright (C) 2006 ADVANCED MICRO DEVICES
>  *
>  * This code is under GPL
>  *
>  * main change log:
>  *  
>  */

It's better than nothing, but I would rather use the full GPL header,
because that

 - includes a "no warranty" phrase
 - explicitly states whether it's "GPL v2" or "GPL v2 or later"
 - is the de-facto standard used in 98% or so of all GPL'd projects

As for the changelog, I don't think that's necessary. That information
is contained in the svn commit logs (at least it should), there's no
need to duplicate it in the files...


HTH, Uwe.
-- 
Uwe Hermann 
http://www.hermann-uwe.de
http://www.it-services-uh.de  | http://www.crazy-hacks.org 
http://www.holsham-traders.de | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20061005/480741f5/attachment.sig>