[LinuxBIOS] indent

Uwe Hermann uwe at hermann-uwe.de
Fri Oct 6 20:01:16 CEST 2006


out of curiosity I tried running indent on the whole source tree,
and then running abuild to see whether things break.
Short answer: they do.

I used thislittle script to indent the code:

for f in `find . -name '*.[ch]'`; do
  indent -kr -i8 -ts8 -sob -l80 -ss -ncs $f 

abuild fails because some code will be broken in the process, and some
code will still work but look ugly.

There are workarounds though, you can enclose paragraphs which should not
be touched by indent as follows:

  /* *INDENT-OFF* */

  /* *INDENT-ON* */

I suggest we should agree on some set of parameters for indent, add
INDENT-OFF/INDENT-ON to the code where appropriate and then, as soon
as abuild doesn't complain anymore, checkin the indented code.

New checkins which don't conform to the coding style (and other
guidelines which may apply) should not be allowed from that point on.


Uwe Hermann 
http://www.it-services-uh.de  | http://www.crazy-hacks.org 
http://www.holsham-traders.de | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20061006/90faf797/attachment.sig>

More information about the coreboot mailing list