[LinuxBIOS] r2578 - trunk/LinuxBIOSv2/util/flashrom
uwe at hermann-uwe.de
Mon Apr 2 00:21:39 CEST 2007
On Sun, Apr 01, 2007 at 11:24:41PM +0200, Luc Verhaegen wrote:
> On Sun, Apr 01, 2007 at 10:00:32PM +0200, svn at openbios.org wrote:
> > Author: uwe
> > Date: 2007-04-01 22:00:32 +0200 (Sun, 01 Apr 2007)
> > New Revision: 2578
> > Modified:
> > trunk/LinuxBIOSv2/util/flashrom/flash.h
> > Log:
> > Drop useless and partly even incorrect comments (trivial).
> Was this really necessary?
> No, i'm not against clean-ups, and i like nothing better than clean,
> beautiful code. But adjusting coding style or comments, simply for the
> sake of beautification usually is just disruptive.
> Especially with at least one flashrom patch waiting for an ACK, a patch
> that already won't apply cleanly anymore thanks to the ICH7 commit.
Yep, the ICH7 commit broke your patch, sorry. This commit didn't, though.
To apply your patch delete the ICH7DH line, apply the patch, re-add the
ICH7DH line in chipset_enable.c. Not a big problem.
I carefully avoided to break your patch with the cleanups I did today.
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: Digital signature
More information about the coreboot