[LinuxBIOS] filo ide speedup patch!

Peter Stuge stuge-linuxbios at cdy.org
Thu Apr 5 22:59:47 CEST 2007

On Thu, Apr 05, 2007 at 02:30:48PM -0400, Ward Vandewege wrote:
> > New patch with bug fixed and more debugging output is attached.
> OK, output attached - it got further this time, but not far enough.

It's starting to look good.

Please apply the attached patch on top of your current code. This
simply removes the check that tripped up the read process from the
FILO IDE driver.

The OpenBIOS IDE driver doesn't have it but it was in the FILO IDE
driver before and I wasn't sure if I should keep it but left it in
for good measure. It seems to cause problems.

> Note that there were a few extra lines on the screen that were not
> present on the serial console:

Incomplete error checking in my new code. I've added that to my tree
now and will send a signed-off patch once you and Stefan test OK.

-------------- next part --------------
--- drivers/ide.c.orig	2007-04-05 22:20:10.000000000 +0200
+++ drivers/ide.c	2007-04-05 22:20:31.000000000 +0200
@@ -405,11 +405,6 @@
 	} while(bytes);
-	status = inb(IDE_REG_STATUS(ctrl));
-	if (status & IDE_STATUS_DRQ) {
-		print_status(ctrl);
-		return -1;
-	}
 	return 0;

More information about the coreboot mailing list