[LinuxBIOS] [PATCH] Fix bug causing flash corruption during verify

Stefan Reinauer stepan at coresystems.de
Sun Aug 12 17:18:49 CEST 2007

* Peter Stuge <peter at stuge.se> [070811 04:41]:
> > The attached patch removes the seemingly unnecessary restoring of
> > the value at location 0 in probe_28sf040(), and indeed fixes the
> > problem.
> We can't say if that restore really is neccessary or not. Erring on
> the side of caution would be good, but the damage may already have
> been done by those certain writes that are needed to do the ID.
I think it is not necessary nor safe for any flash media in that area.
Of course, if we fear that we might find non-flash media in the 4G-size
area, we need to think about restoring.

> Maybe we should just not probe for 28sf040 by default? It's a really
> old chip.

Or remove the restore? The code only restores for the case that there is
no 28sf040 anyways...?

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/

More information about the coreboot mailing list