[LinuxBIOS] [PATCH] Fix bug causing flash corruption during verify

Peter Stuge peter at stuge.se
Mon Aug 13 05:57:40 CEST 2007


On Sun, Aug 12, 2007 at 05:18:49PM +0200, Stefan Reinauer wrote:
> Of course, if we fear that we might find non-flash media in the
> 4G-size area, we need to think about restoring.

Yeah. When we want to port flashrom to flash also on other archs, it
will need a redesign. I don't care for now.


> > Maybe we should just not probe for 28sf040 by default? It's a
> > really old chip.
> 
> Or remove the restore?

I like that. No other probe_ functions restore like that.


> The code only restores for the case that there is no 28sf040
> anyways...?

And that's the problem - because typically there is none, so that
byte will always get written. Most chips don't care, but apparently
some do.


//Peter




More information about the coreboot mailing list