[LinuxBIOS] flashrom geodelx patch
Marc Jones
marc.jones at amd.com
Wed Aug 15 21:07:15 CEST 2007
Tom Sylla wrote:
> This patch is not quite correct.
>
> The MSR being written is RCONF_DEFAULT_MSR (0x1808). That MSR includes
> SYSTOP (where RAM ends). That should be dynamic depending on the
> amount of RAM in the system, you can't really just smash in a fixed
> value. The correct thing to do is to read the MSR, clear WP of the
> ROMRP field, and write it back. Doing it this way would make it proper
> and much cleaner (and self-documented).
>
> (if anyone wonders what the fields mean, just read the LX databook)
>
Thanks Tom! Couldn't put it better myself. :)
Marc
--
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
http://www.amd.com/embeddedprocessors
More information about the coreboot
mailing list