[LinuxBIOS] [PATCH] v3: fix msm800sev early serial

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Aug 30 02:12:54 CEST 2007

The ADL MSM800SEV had SERIAL_DEV hardcoded to 0x30, although it should
be W83627HF_SP1 which is 0x2. Fix it and replace magic constants with

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

--- LinuxBIOSv3/mainboard/adl/msm800sev/stage1.c	(Revision 485)
+++ LinuxBIOSv3/mainboard/adl/msm800sev/stage1.c	(Arbeitskopie)
@@ -33,7 +33,8 @@
 #include <southbridge/amd/cs5536/cs5536.h>
 #include <superio/winbond/w83627hf/w83627hf.h>
-#define SERIAL_DEV 0x30
+#define SERIAL_DEV W83627HF_SP1
+#define SERIAL_IOBASE 0x3f8
 void hardware_stage1(void)
@@ -49,6 +50,6 @@
 	 * for cs5536
-	w83627hf_enable_serial(0x2e, 0x30, 0x3f8);
+	w83627hf_enable_serial(0x2e, SERIAL_DEV, SERIAL_IOBASE);
 	printk(BIOS_DEBUG, "Done %s\n", __FUNCTION__);

More information about the coreboot mailing list