[LinuxBIOS] Expand linuxbiosv3 support

Myles Watson myles at pel.cs.byu.edu
Fri Dec 7 15:40:35 CET 2007



> -----Original Message-----
> From: Jordan Crouse [mailto:jordan.crouse at amd.com]
> Sent: Thursday, December 06, 2007 4:47 PM
> To: Myles Watson
> Cc: linuxbios at linuxbios.org
> Subject: Re: Expand linuxbiosv3 support
> 
> On 06/12/07 16:32 -0700, Myles Watson wrote:
> > It complains that the logs directory doesn't exist when it tries to
> fetch
> > and create the linuxbiosv3/logs/fetch.log file.
> 
> oops - my bad - I can fix that.
> 
> > I prefer to have LinuxBIOSv2 and LinuxBIOSv3 represented in the same
> way.  I
> > think it's confusing to have one be LBV3 and one LINUXBIOS.  It seems
> like
> > LINUXBIOS should be used in the generic case, and things that are
> specific
> > to v2 or v3 should be labeled that way.
> 
> The problem is that v2 and v3 are way too different - so regardless of
> the nomenclature, you're going to need to have ifeq statements everywhere,
> and I personally think that is messier then having different variables
> names.  If you want, we _can_ reuse the variables since we're only
> including
> either the v2 or the v3 .mk file, but to me that makes things more
> confusing
> to the person porting the platform.

I was just voting for the variables to look the same if they were the same.
(LINUXBIOS_V2_BUILD_DIR and LINUXBIOS_V3_BUILD_DIR or LBV2_BUILD_DIR and
LBV3_BUILD_DIR)  

I wasn't complaining about the separation.

Myles






More information about the coreboot mailing list