[LinuxBIOS] [PATCH] many trivial patches

Myles Watson myles at pel.cs.byu.edu
Fri Dec 7 20:58:23 CET 2007


> > > This is a resend.  Does anyone have objections to this patch still?
> >
> > Did you check with abuild that all boards still build fine after the
> > patch? Did you compare the sizes, i.e. does it make a real difference
> > in behaviour of the build, or is it just a "cosmetical" change?
> 
> It's not cosmetic. Without this patch, we can't have an LZMA precompressed
> payload for the board (which is an option in buildrom).

As I understand it, all the precompressed payload option does is tells the
build process not to try to run lzma on the payload when LZMA compression is
enabled.  

It allows buildrom to use its own compiled version of lzma instead of the
one that the user might have in his path.

Since I didn't set the variable, but just allowed it to be set in the
future, my hypothesis is that it changes nothing for abuild.

I'm running abuild now.

> 
> If the boards still build (which I suspect they will),
> 
> Acked-by: Ward Vandewege <ward at gnu.org>

Thanks,
Myles







More information about the coreboot mailing list