[LinuxBIOS] [PATCH] amdk8_sysconf.h type corrected

Uwe Hermann uwe at hermann-uwe.de
Thu Feb 1 02:47:34 CET 2007

On Wed, Jan 31, 2007 at 03:42:47PM -0700, ron minnich wrote:
> On 1/31/07, Peter Stuge <stuge-linuxbios at cdy.org> wrote:
> > Please have a look at http://linuxbios.org/Development_Guidelines
> > and specifically the "How to contribute" section, so your patches
> > can make it into svn faster.
> apropos this comment. Could someone add a little clarification about
> what happens once an Acked-by: is added?
> I would assume that if someone with commit rights adds an acked-by:,
> they take responsibility for the commit. But that is not spelled out.

Yes, basically. The Signed-off-by is legally important to have a clear
statement from the contributors that they can and want to legally contribute
the code under the GPL etc., while the Acked-by is just a mechanism to
somewhat enforce peer review of the patches.

One Acked-by is the minimum which is required to be able to commit a
patch (the more the better, of course). This means at least two people
looked at the patch and didn't notice any glaring bugs/problems (the
patch submitter + the one who sent the Acked-by).

People without svn commit access are welcome to review patches and send
Acked-by's too, but obviously someone _with_ commit access has to do
the actual commit then.

Cheers, Uwe.
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070201/79ab9448/attachment.sig>

More information about the coreboot mailing list