[LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super I/O
Lu, Yinghai
yinghai.lu at amd.com
Wed Feb 28 18:22:36 CET 2007
In the V2 you need to everyone happy
1. ROMCC: print
2. CAR: a. print
b. printk
c. print when ram is enabled already
d. printk when ram is enabled already
c/d are introduced for USBDebug direct, because dbg_info will be in RAM
instead of cache..
dbg_info will contain the BAR info that is needed for dbgp_bulk_write_x
check pc80/usbdebug_dirct_serial.c for more
YH
-----Original Message-----
From: Stefan Reinauer [mailto:stepan at coresystems.de]
Sent: Wednesday, February 28, 2007 6:53 AM
To: Carl-Daniel Hailfinger
Cc: Lu, Yinghai; Stefan Reinauer; linuxbios at linuxbios.org
Subject: Re: [LinuxBIOS] [PATCH] Support for Winbond W83627EHG Super I/O
* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [070228
15:19]:
> The current printk stuff is a mess. Yinghai at least tried to clean
> this up, but his tree diverged and so we have an even bigger mess.
>
> Look at current svn and see the horror:
> ./src/arch/ppc/include/printk.h is a subset of
> ./src/include/console/console.h is a subset of
> ./src/arch/i386/lib/console.c
> Duplicated code everywhere.
>
> Suggestion: Look at the diff between
LB-svn/src/arch/i386/lib/console.c
> and LB-yhlu/src/arch/i386/lib/console_printk.c and see that moving
code
> between files helps readability. I can prepare a patch without
functional
> changes if anyone agrees.
Please do!
--
coresystems GmbH * Brahmsstr. 16 * D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 * Fax: +49 761 7664613
Email: info at coresystems.de * http://www.coresystems.de/
More information about the coreboot
mailing list