[LinuxBIOS] [PATCH] v3: Move htl() into cpu.h

Uwe Hermann uwe at hermann-uwe.de
Sun Jul 1 00:31:18 CEST 2007


On Sat, Jun 30, 2007 at 02:35:04PM -0700, ron minnich wrote:
> On 6/30/07, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> >See patch.
> >
> >Do we really need or want the "__attribute__((always_inline))"?
> 
> Only rarely.
> 
> Why we would need it for hlt()? So, in case memory is totally not
> working, we don't do a call and try to push stuff on a stack. We want
> it inline.
> 
> There are very few cases where we should apply always_inline.

OK, I see, thanks. Patch updated.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_hlt.patch
Type: text/x-diff
Size: 3940 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070701/1e1a5eb7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070701/1e1a5eb7/attachment.sig>


More information about the coreboot mailing list