[LinuxBIOS] [PATCH] v3 - put lar size in the bootblock

Stefan Reinauer stepan at coresystems.de
Sun Jul 1 00:49:05 CEST 2007


* Uwe Hermann <uwe at hermann-uwe.de> [070701 00:11]:
> > +       int i;
> > +       uint32_t *size_pos;
> 
> u32
 
No, this is userspace. We don't have u32 here.

 
> > -                       if (strcmp("lzma", optarg) == 0) {
> > +                       if (strcasecmp("lzma", optarg) == 0) {
> 
> OK, I guess, but not all systems might have strcasecmp (I think it's
> called stricmp() on some). Not critical right now, though...
 
ieks. good point. Which are those again?

> > +        */
> > +       archive.len = *(u32 *)0xfffffff4;
> > +       archive.start =(void *)(0UL-archive.len);
>  
> 
> Something seems wrong with the patch, doesn't apply here (mailer issue?)

Yes, whitespaces are broken. I can't get the patches to my mailer except
cut and paste :-((( ssh works, scp does not 

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/




More information about the coreboot mailing list