[LinuxBIOS] [PATCH] v3: 8254_pit.patch

Uwe Hermann uwe at hermann-uwe.de
Wed Jul 4 19:43:36 CEST 2007

On Tue, Jul 03, 2007 at 06:19:48PM -0600, Marc Jones wrote:
>> Yep, but the 0x56 and 0x12 should be #defines (or have comments), too.
> The 0x56 and 0x12 are well commented in the function header.

Ah, yes, I should have looked a bit closer.

> Moved some generic 8254 PIT #defines out of the speaker code to legacy.h.
> Use legacy.h PIT defines in Geode code.
> Signed-off-by: Marc Jones <marc.jones at amd.com>

Looks good to me.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070704/006559eb/attachment.sig>

More information about the coreboot mailing list