[LinuxBIOS] Allow human friendly suffixes for the size option
jordan.crouse at amd.com
Thu Jul 12 01:41:21 CEST 2007
On 12/07/07 01:19 +0200, Peter Stuge wrote:
> Great idea.
> On Wed, Jul 11, 2007 at 12:26:16PM -0600, Jordan Crouse wrote:
> > + printf(" \tUse a 'k' suffix to multiply the size by 1K or\n");
> > + printf(" \ta 'm' suffix to multiple the size by 1M.\n");
> I would prefer 1024 rather than 1K and 1048576 or 1024*1024 rather
> than 1M.
Good idea. I think 'dd' does the same thing.
> > +static void parse_larsize(char *str)
> static u32 ..
> > + larsize = size;
> .. and return size ?
> May it's useful somewhere else too? Ie. move to lib.c?
I don't know - this is the only place we do this sort of thing -
in fact, its probably overkill to have a function - we could do it
right in the switch statement if we wanted to.
Systems Software Development Engineer
Advanced Micro Devices, Inc.
More information about the coreboot