[LinuxBIOS] [v3][PATCH] stage0 and stage1 cleanup and improvements.

Stefan Reinauer stepan at coresystems.de
Fri Jul 20 00:02:56 CEST 2007

* Marc Jones <Marc.Jones at AMD.com> [070719 23:52]:
> I only think that this is a problem with initram because it links to 
> stage0. Maybe we should reconsider that. Maybe it needs to stand alone.
> Marc

There are a few functions that we might want to share:

- printk
- the lar functions (?? not sure, maybe not even those.)
- what else?

One thing we had in v2 was 6 incarnations of print(k), each in 10
incarnations, one for each log level. That made 60 functions just for
pushing a few letters of _debug_ to the _developer_.

Maybe we have to duplicate printk in the binary, but we should try to
keep it one incarnation in the code.

If it is only for printk, setting up a jump table is maybe not worth it.

Though stage2 will have one, too.

Modular design and it's advantages and disadvantages. I think we should
try to go the "defined interface to stage0" way, as Juergen also
suggested (I dont think this is a hack)

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/

More information about the coreboot mailing list