[LinuxBIOS] [PATCH] v3 - warn about printk failures.

Stefan Reinauer stepan at coresystems.de
Fri Jul 20 02:45:29 CEST 2007


Hi

Wonderful gcc-isms :-) I learned something new today that I want to
share.

This one warns about printk parameters.

I don't claim we should check this in, but we should at least fix the
warnings it brings..  

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

Index: include/console.h
===================================================================
--- include/console.h	(revision 459)
+++ include/console.h	(working copy)
@@ -46,6 +46,7 @@
 };
 
 // 
-int printk(int msg_level, const char *fmt, ...);
+int printk(int msg_level, const char *fmt, ...) 
+	__attribute__((format (printf, 2, 3)));
 
 #endif /* CONSOLE_H */

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/




More information about the coreboot mailing list