[LinuxBIOS] [PATCH] [v3] create map files, clean up

Juergen Beisert juergen127 at kreuzholzen.de
Mon Jul 23 12:35:55 CEST 2007


Hi Stefan,

On Sunday 22 July 2007 17:47, Stefan Reinauer wrote:
> see patch

Arrg. We are in make not in shell...

> +# These are possibly not permanent
> +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/lib/console.o
> +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/lib/vtxprintf.o
> +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/lib/uart8250.o
> +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/arch/x86/post_code.o

This is a way to go and also it shows every reader what you *intent* to do:

INITRAM_OBJ := $(obj)/lib/console.o
INITRAM_OBJ += $(obj)/lib/vtxprintf.o
INITRAM_OBJ += $(obj)/lib/uart8250.o
INITRAM_OBJ += $(obj)/arch/x86/post_code.o

Or choose the way Uwe mentioned. But do not use the variable itself to append 
something to it.

Juergen




More information about the coreboot mailing list