[LinuxBIOS] [PATCH] [v3] create map files, clean up

Stefan Reinauer stepan at coresystems.de
Mon Jul 23 12:47:21 CEST 2007


* Juergen Beisert <juergen127 at kreuzholzen.de> [070723 12:35]:
> Hi Stefan,
> 
> On Sunday 22 July 2007 17:47, Stefan Reinauer wrote:
> > see patch
> 
> Arrg. We are in make not in shell...
> 
> > +# These are possibly not permanent
> > +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/lib/console.o
> > +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/lib/vtxprintf.o
> > +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/lib/uart8250.o
> > +INITRAM_OBJ := $(INITRAM_OBJ) $(obj)/arch/x86/post_code.o
> 
> This is a way to go and also it shows every reader what you *intent* to do:
> 
> INITRAM_OBJ := $(obj)/lib/console.o
              ^^^ +=
> INITRAM_OBJ += $(obj)/lib/vtxprintf.o
> INITRAM_OBJ += $(obj)/lib/uart8250.o
> INITRAM_OBJ += $(obj)/arch/x86/post_code.o
> 
> Or choose the way Uwe mentioned. But do not use the variable itself to append 
> something to it.

Ok, will change this. Though I don't think it makes a big difference
internally. Both ways just append a string to another one..


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866




More information about the coreboot mailing list