[LinuxBIOS] [patch 5/5] Allow human friendly suffixes for the size option
Peter Stuge
peter at stuge.se
Mon Jul 23 19:37:08 CEST 2007
On Mon, Jul 23, 2007 at 10:06:07AM -0600, jordan.crouse at amd.com wrote:
> +static void parse_larsize(char *str)
> +{
> + char *p = NULL;
> + unsigned int size = strtoul(str, &p, 0);
larsize is declared a long while parse_larsize() now uses strtoul() -
they should match.
> case 's':
> - larsize = strtol(optarg, (char **)NULL, 10);
> + parse_larsize(optarg);
Another issue was already discussed;
Either make parse_larsize() return a value, or put the code in the
case.
File global larsize is yucky and hurts reuse.
//Peter
More information about the coreboot
mailing list