[LinuxBIOS] Added mainboard commell/lv671 and compile works, but ...

[Dieter Bloms]

Hi,

On Wed, Jun 06, Uwe Hermann wrote:

> On Wed, Jun 06, 2007 at 08:36:31AM +0200, Dieter Bloms wrote:
> > I have tared my stuff, maybe someone is willing to have a look at it:
> > 
> > http://www.bloms.de/download/commell_lv671.tar.gz
> 
> Please always post (signed-off) patches, tarballs are hard to review and
> comment on. 

ok, I will do it in future.

> In Config.lb you have
> 
>   option ROM_SIZE=512*1024+128*1024
> 
> which looks wrong. ROM_SIZE is the size of your chip, which is
> probably 512*1024.

without +128*1024 I got a to liddle rom file, but I will correct this
and will see, where to change values to get the right rom sizes.
I saw this by another motherboards like tyan/s2850 board

> Issue 2:
> 
>   option USE_FALLBACK_IMAGE=0
> 
> should probably be set to 1. If you only use one image it has to be the
> fallback image AFAIK, otherwise it won't work.

ok, will change that.

> Other than that I cannot spot any obvious problems with the code, it
> _should_ work, usually...


-- 
Gruß

  Dieter

--
I do not get viruses because I do not use MS software.
If you use Outlook then please do not put my email address in your
address-book so that WHEN you get a virus it won't use my address in the
From field.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070607/db3d5a36/attachment.sig>