[LinuxBIOS] [PATCH] v3 drop malloc, clean up device model

Stefan Reinauer stepan at coresystems.de
Fri Jun 29 18:50:14 CEST 2007

* ron minnich <rminnich at gmail.com> [070629 18:36]:
>  Let's drop the "gcc hack" comment, it no longer applies.

>  	if (!dev)
>  -		printk(BIOS_DEBUG, "%s: No constructor, going with empty dev",
>  -		       dev_id_string(devid));
>  +		return NULL;
>  are you missing a spin_unlock here? If we are doing lock/unlock then
>  the failure case should probably be a goto Error in the kernel style,
>  so we don' t leave a dangling lock.

Oh yeah! Even though this case does usually mean we can not really

new patch ...
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_drop_malloc2.diff
Type: text/x-patch
Size: 18059 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070629/4ea8c950/attachment.diff>

More information about the coreboot mailing list