[LinuxBIOS] [PATCH] v3: cpu.h improvements (take 2)

Uwe Hermann uwe at hermann-uwe.de
Sat Jun 30 17:17:36 CEST 2007

On Wed, Jun 27, 2007 at 07:06:12AM -0400, Corey Osgood wrote:
> Is there any reason not to combine these two functions? Maybe it's just
> me, but I don't like seeing one function call another, make some menial
> changes then call a third, all with the exact same variables, and to
> complete one task.

Good point. The Linux file is a lot more generic (there's also a
cpuid_count() function which is a bit different and uses the generic
function), but all of this is not needed in LinuxBIOS, I guess.

New patch attached. The code is now even shorter and simpler.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_cpu_fixes.patch
Type: text/x-diff
Size: 8234 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070630/12c2f396/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070630/12c2f396/attachment.sig>

More information about the coreboot mailing list