[LinuxBIOS] [PATCH] Add initial serial output for Via vt82c686
uwe at hermann-uwe.de
Sat Mar 17 15:03:15 CET 2007
Committed in r2571, thanks!
On Sat, Mar 17, 2007 at 12:01:28AM -0400, Corey Osgood wrote:
> >If it works (and if you don't spot further problems in the code) I'd say
> >can be committed. Please send an Acked-by if the code looks good to you.
> Awesome! I was starting to get concerned that I'd done something that
> only worked on my board. I've got no problem with your changes (although
> I can't _find_ an io base), and the code works fine on my board.
Yep, iobase is not used yet. I guess we should make these two lines
dependant on the value of iobase?
+ vt82c686_sio_write(VT82C686_SP1, 0xfe); /* SP1: 0x3f8 */
+ vt82c686_sio_write(VT82C686_SP2, 0xbe); /* SP2: 0x2f8 */
> die() in console/console.c does send a post code, but if I try to use
> it, gcc gives an error about function type pointers that I haven't been
> able to track down the cause of. The die() src/arch/i386/lib/console.c
> doesn't send a post code, and that's the one I'm currently using, since
> that's what whichever motherboard I based my code on was using. So,
> either that console.c should get fixed up, or I should figure out why I
> can't use the other one (or even both).
Hm, strange. I'll have a look later. Shall we hardcode a post_code()
call in addition of die() for now?
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: Digital signature
More information about the coreboot