[LinuxBIOS] [PATCH] Add support for the NSC PC87309 Super I/O
uwe at hermann-uwe.de
Sat Mar 31 04:09:32 CEST 2007
On Sat, Mar 31, 2007 at 01:13:46AM +0200, Stefan Reinauer wrote:
> * Uwe Hermann <uwe at hermann-uwe.de> [070331 00:11]:
> > Index: src/superio/nsc/pc87309/pc87309.h
> > ===================================================================
> > --- src/superio/nsc/pc87309/pc87309.h (Revision 0)
> > +++ src/superio/nsc/pc87309/pc87309.h (Revision 0)
> > @@ -0,0 +1,30 @@
> > +#define PC87309_FDC 0x00 /* Floppy */
> > +#define PC87309_PP 0x01 /* Parallel port */
> > +#define PC87309_SP2 0x02 /* Com2 / IR */
> > +#define PC87309_SP1 0x03 /* Com1 */
> > +#define PC87309_PM 0x04 /* Power management */
> > +#define PC87309_KBCM 0x05 /* Mouse */
> > +#define PC87309_KBCK 0x06 /* Keyboard */
> Since these defines are only ever used in one single file, it should not
> be an extra include file, but part of superio.c
> In order to make the code more reusable I suggest also dropping the
> PC87309_ prefix
I already dropped the prefix on almost all variables and function names.
For the remaining ones I think it makes sense to keep them.
For example, PC87309_SP1 is used in the auto.c file of the respective
board to enable the Super I/O and use COM1.
I don't know for sure whether it makes sense to have the defines in an
extra file, but pretty much _all_ other Super I/Os have them in an extra
file... So I think we should keep it that way for consistency reasons,
or change the behavior for _all_ Super I/Os. Comments?
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: Digital signature
More information about the coreboot