[LinuxBIOS] [PATCH] Add support for the NSC PC87309 Super I/O
stepan at coresystems.de
Sat Mar 31 20:20:01 CEST 2007
* Uwe Hermann <uwe at hermann-uwe.de> [070331 04:09]:
> I already dropped the prefix on almost all variables and function names.
> For the remaining ones I think it makes sense to keep them.
> For example, PC87309_SP1 is used in the auto.c file of the respective
> board to enable the Super I/O and use COM1.
Ah ok, this might be important on boards with more than one superio.
Or maybe we should find a unique abstraction for this?
> I don't know for sure whether it makes sense to have the defines in an
> extra file, but pretty much _all_ other Super I/Os have them in an extra
> file... So I think we should keep it that way for consistency reasons,
> or change the behavior for _all_ Super I/Os. Comments?
Yes. I think all other SuperIOs are doing the wrong thing, too. An
include is there to share information between files. If information is
not shared, it should be local.
Anyways, I think we might have reasons to expect SuperIOs dying out
from the next generation boards.
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
More information about the coreboot