[LinuxBIOS] [PATCH] Add support for the NSC PC87309 Super I/O

[Stefan Reinauer]

* Uwe Hermann <uwe at hermann-uwe.de> [070331 20:53]:
> On Sat, Mar 31, 2007 at 08:20:01PM +0200, Stefan Reinauer wrote:
> > * Uwe Hermann <uwe at hermann-uwe.de> [070331 04:09]:
> > > I already dropped the prefix on almost all variables and function names.
> > > For the remaining ones I think it makes sense to keep them.
> > > 
> > > For example, PC87309_SP1 is used in the auto.c file of the respective
> > > board to enable the Super I/O and use COM1.
> >  
> > Ah ok, this might be important on boards with more than one superio.
> > 
> > Or maybe we should find a unique abstraction for this?
> 
> On the long run (and for v3), maybe. But for now I'd like to get this
> committed and fix up _all_ Super I/Os at the same time later...
 
oh of course. 

> > Yes. I think all other SuperIOs are doing the wrong thing, too. An
> > include is there to share information between files. If information is
> > not shared, it should be local.
> 
> AFAICS the include files _are_ used elsewhere in the code (for some
> Super I/Os, at least):
> 
> $ rgrep w83627hf.h * | grep -v .svn
> src/superio/winbond/w83627hf/superio.c:#include "w83627hf.h"
> src/superio/winbond/w83627hf/w83627hf_early_serial.c:#include "w83627hf.h"
> src/superio/winbond/w83627hf/w83627hf_early_init.c:#include "w83627hf.h"
> src/mainboard/dell/s1850/auto.c:#include "superio/winbond/w83627hf/w83627hf.h"
> src/mainboard/supermicro/x6dai_g/auto.c:#include "superio/winbond/w83627hf/w83627hf.h"
> src/mainboard/supermicro/x6dhe_g/auto.c:#include "superio/winbond/w83627hf/w83627hf.h"
> src/mainboard/supermicro/x6dhe_g2/auto.updated.c:#include "superio/winbond/w83627hf/w83627hf.h"
> src/mainboard/supermicro/x6dhr_ig/auto.c:#include "superio/winbond/w83627hf/w83627hf.h"
> src/mainboard/supermicro/x6dhr_ig2/auto.c:#include "superio/winbond/w83627hf/w83627hf.h"

ah, ok then forget my comment. instead

Acked-by: Stefan Reinauer <stepan at coresystems.de>


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/