[LinuxBIOS] [patch 2/4] Geode LX: Norwich mainboard
marc.jones at amd.com
Wed May 2 21:49:25 CEST 2007
ron minnich wrote:
> On 5/1/07, Uwe Hermann <uwe at hermann-uwe.de> wrote:
>> On Tue, May 01, 2007 at 04:48:29PM -0600, Marc Jones wrote:
>> > This patch adds support for the AMD Norwich development platform
>> > based on the Geode LX processor. The Norwich is the canonical
>> > Geode reference, and will server as a good basis for other
>> > Geode based platforms.
>> So is this a physically existing product or merely a development
>> board/prototype? I'm asking because I'd like to know into which
>> category this should go later in the wiki:
> I'd say put it in as supported.
>> > +#define POST_CODE(x) outb(x, 0x80)
>> Why this? We have a post_code() function in src/console/console.c.
> Marc, is it possible to use the standard one? (There may be a reason
> for the macro, if so, leave it in)
This was for pre-stack code when we were using romcc. Now that it is CAR
code I think it could be changed to use console.c.
>> > + SystemPreInit();
>> > + pll_reset(ManualConf);
>> > +
>> > + cpuRegInit();
> Those names may be the fault of Ollie or me, not sure; Marc, change if
> you wish.
I think this would be best as a follow-on patch.
> So, I'm with Peter, I'd go for the
> Acked-by: Ronald G. Minnich <rminnich at gmail.com>
> and, Marc, consider either a new patch with Uwe's recommendations or
> fixup later. But I don't want to delay getting this in; there are some
> customers waiting for it, literally daily.
Senior Software Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot