[LinuxBIOS] [patch 08/10] Geode LX: Northbridge
stuge-linuxbios at cdy.org
Fri May 4 03:25:17 CEST 2007
On Thu, May 03, 2007 at 12:15:56PM -0600, Marc Jones wrote:
> This patch adds support for the northbridge integrated into the AMD
> Geode LX platform, including memory and graphics.
Nak again due to whitespace although it is not as severe as in the
> +int sizeram(void)
It would be nice to have a small comment on the algorithm used by
this function and a reference to some documentation.
> - printk_debug("sizeram: sizem 0x%x\n", sizem);
> + printk_debug("sizeram: sizem 0x%xMB\n", sizem);
I think %d would be nicer. :)
> + print_debug("\r\n");
Please use only \n for line endings.
More information about the coreboot