[LinuxBIOS] r2650 - trunk/LinuxBIOSv2/src/cpu/amd/model_lx

svn at openbios.org svn at openbios.org
Thu May 10 20:32:28 CEST 2007


Author: stepan
Date: 2007-05-10 20:32:28 +0200 (Thu, 10 May 2007)
New Revision: 2650

Modified:
   trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpubug.c
   trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c
   trunk/LinuxBIOSv2/src/cpu/amd/model_lx/model_lx_init.c
   trunk/LinuxBIOSv2/src/cpu/amd/model_lx/syspreinit.c
   trunk/LinuxBIOSv2/src/cpu/amd/model_lx/vsmsetup.c
Log:
Fix the indent and whitespace to match LinuxBIOS standards

Signed-off-by: Jordan Crouse <jordan.crouse at amd.com>
Acked-by: Stefan Reinauer <stepan at coresystems.de>



Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpubug.c
===================================================================
--- trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpubug.c	2007-05-10 18:16:03 UTC (rev 2649)
+++ trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpubug.c	2007-05-10 18:32:28 UTC (rev 2650)
@@ -30,7 +30,6 @@
 #include <cpu/x86/msr.h>
 #include <cpu/amd/lxdef.h>
 
-
 /**************************************************************************
  *
  *	pcideadlock
@@ -40,27 +39,27 @@
  *	There is also fix code in cache and PCI functions. This bug is very is pervasive.
  *
  **************************************************************************/
-static void pcideadlock(void){
+static void pcideadlock(void)
+{
 	msr_t msr;
 
 	/*
 	 * forces serialization of all load misses. Setting this bit prevents the 
 	 * DM pipe from backing up if a read request has to be held up waiting 
 	 * for PCI writes to complete.
-	*/
+	 */
 	msr = rdmsr(CPU_DM_CONFIG0);
 	msr.lo |= DM_CONFIG0_LOWER_MISSER_SET;
 	wrmsr(CPU_DM_CONFIG0, msr);
 
-	
 	/* write serialize memory hole to PCI. Need to unWS when something is 
 	 * shadowed regardless of cachablility.
 	 */
 	msr.lo = 0x021212121;
 	msr.hi = 0x021212121;
-	wrmsr( CPU_RCONF_A0_BF, msr);
-	wrmsr( CPU_RCONF_C0_DF, msr);
-	wrmsr( CPU_RCONF_E0_FF, msr);
+	wrmsr(CPU_RCONF_A0_BF, msr);
+	wrmsr(CPU_RCONF_C0_DF, msr);
+	wrmsr(CPU_RCONF_E0_FF, msr);
 }
 
 /****************************************************************************/
@@ -74,17 +73,19 @@
 /**	 to maintain coherency with and the cache is not enabled yet.*/
 /***/
 /****************************************************************************/
-static void disablememoryreadorder(void){
+static void disablememoryreadorder(void)
+{
 	msr_t msr;
 
 	msr = rdmsr(MC_CF8F_DATA);
-	msr.hi |=  CF8F_UPPER_REORDER_DIS_SET;
+	msr.hi |= CF8F_UPPER_REORDER_DIS_SET;
 	wrmsr(MC_CF8F_DATA, msr);
 }
 
 /* For cpu version C3. Should be the only released version */
-void cpubug(void) {
-			pcideadlock();
+void cpubug(void)
+{
+	pcideadlock();
 	disablememoryreadorder();
 	printk_debug("Done cpubug fixes \n");
 }

Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c
===================================================================
--- trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c	2007-05-10 18:16:03 UTC (rev 2649)
+++ trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c	2007-05-10 18:32:28 UTC (rev 2650)
@@ -25,7 +25,8 @@
 ;*	SetDelayControl
 ;*
 ;*************************************************************************/
-void SetDelayControl(void){
+void SetDelayControl(void)
+{
 	unsigned int msrnum, glspeed;
 	unsigned char spdbyte0, spdbyte1;
 	msr_t msr;
@@ -37,7 +38,7 @@
 	msr.hi = 0;
 	msr.lo = 0x2814D352;
 	wrmsr(msrnum, msr);
-	
+
 	msrnum = CPU_BC_MSS_ARRAY_CTL1;
 	msr.hi = 0;
 	msr.lo = 0x1068334D;
@@ -46,8 +47,8 @@
 	msrnum = CPU_BC_MSS_ARRAY_CTL2;
 	msr.hi = 0x00000106;
 	msr.lo = 0x83104104;
-	wrmsr(msrnum,msr);
- 
+	wrmsr(msrnum, msr);
+
 	msrnum = GLCP_FIFOCTL;
 	msr = rdmsr(msrnum);
 	msr.hi = 0x00000005;
@@ -59,39 +60,35 @@
 	msr.lo = 0x00000001;
 	wrmsr(msrnum, msr);
 
-
 	/* Debug Delay Control Setup Check
-	Leave it alone if it has been setup. FS2 or something is here.*/
+	   Leave it alone if it has been setup. FS2 or something is here. */
 	msrnum = GLCP_DELAY_CONTROLS;
 	msr = rdmsr(msrnum);
-	if (msr.lo & ~(0x7C0)){
+	if (msr.lo & ~(0x7C0)) {
 		return;
 	}
 
-
 	/*
-	; Delay Controls based on DIMM loading. UGH!
-	; # of Devices = Module Width (SPD6) / Device Width(SPD13) * Physical Banks(SPD5)
-	; Note - We only support module width of 64.
-	*/
+	 * Delay Controls based on DIMM loading. UGH!
+	 * # of Devices = Module Width (SPD6) / Device Width(SPD13) * Physical Banks(SPD5)
+	 * Note - We only support module width of 64.
+	 */
 	spdbyte0 = spd_read_byte(DIMM0, SPD_PRIMARY_SDRAM_WIDTH);
-	if (spdbyte0 !=0xFF){
-		spdbyte0 = (unsigned char) 64/spdbyte0 * (unsigned char) (spd_read_byte(DIMM0, SPD_NUM_DIMM_BANKS));
+	if (spdbyte0 != 0xFF) {
+		spdbyte0 = (unsigned char)64 / spdbyte0 *
+		    (unsigned char)(spd_read_byte(DIMM0, SPD_NUM_DIMM_BANKS));
+	} else {
+		spdbyte0 = 0;
 	}
-	else{
-		spdbyte0=0;
-	}
 
 	spdbyte1 = spd_read_byte(DIMM1, SPD_PRIMARY_SDRAM_WIDTH);
-	if (spdbyte1 !=0xFF){
-		spdbyte1 = (unsigned char) 64/spdbyte1 * (unsigned char) (spd_read_byte(DIMM1, SPD_NUM_DIMM_BANKS));
+	if (spdbyte1 != 0xFF) {
+		spdbyte1 = (unsigned char)64 / spdbyte1 *
+		    (unsigned char)(spd_read_byte(DIMM1, SPD_NUM_DIMM_BANKS));
+	} else {
+		spdbyte1 = 0;
 	}
-	else{
-		spdbyte1=0;
-	}
 
-
-
 /* The current thinking. Subject to change...
 
 ;								   "FUTURE ROBUSTNESS" PROPOSAL
@@ -141,117 +138,104 @@
 */
 	msr.hi = msr.lo = 0;
 
-	if (spdbyte0 == 0 || spdbyte1 == 0){
+	if (spdbyte0 == 0 || spdbyte1 == 0) {
 		/* one dimm solution */
-		if (spdbyte1 == 0){
+		if (spdbyte1 == 0) {
 			msr.hi |= 0x000800000;
 		}
 		spdbyte0 += spdbyte1;
-		if (spdbyte0 > 8){
+		if (spdbyte0 > 8) {
 			/* large dimm */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0837100AA;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x082710055;
 				msr.lo |= 0x056960004;
 			}
-		}
-		else if (spdbyte0 > 4){
+		} else if (spdbyte0 > 4) {
 			/* medium dimm */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0837100AA;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x0827100AA;
 				msr.lo |= 0x056960004;
 			}
-		}
-		else{
+		} else {
 			/* small dimm */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0837100FF;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x0827100FF;
 				msr.lo |= 0x056960004;
 			}
 		}
-	}
-	else{
+	} else {
 		/* two dimm solution */
 		spdbyte0 += spdbyte1;
-		if (spdbyte0 > 24){
+		if (spdbyte0 > 24) {
 			/* huge dimms */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0B37100A5;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x0B2710000;
 				msr.lo |= 0x056960004;
 			}
-		}
-		else if (spdbyte0 > 16){
+		} else if (spdbyte0 > 16) {
 			/* large dimms */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0B37100A5;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x0B27100A5;
 				msr.lo |= 0x056960004;
 			}
-		}
-		else if (spdbyte0 >= 8){
+		} else if (spdbyte0 >= 8) {
 			/* medium dimms */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0937100A5;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x0C27100A5;
 				msr.lo |= 0x056960004;
 			}
-		}
-		else{
+		} else {
 			/* small dimms */
-			if (glspeed < 334){
+			if (glspeed < 334) {
 				msr.hi |= 0x0837100A5;
 				msr.lo |= 0x056960004;
-			}
-			else{
+			} else {
 				msr.hi |= 0x082710000;
 				msr.lo |= 0x056960004;
 			}
 		}
 	}
-	wrmsr(GLCP_DELAY_CONTROLS,msr);
+	wrmsr(GLCP_DELAY_CONTROLS, msr);
 	return;
 }
 
 /* ***************************************************************************/
 /* *	cpuRegInit*/
 /* ***************************************************************************/
-void
-cpuRegInit (void){
+void cpuRegInit(void)
+{
 	int msrnum;
 	msr_t msr;
-	
+
 	/* Castle 2.0 BTM periodic sync period. */
-	/*	[40:37] 1 sync record per 256 bytes */
+	/*      [40:37] 1 sync record per 256 bytes */
 	msrnum = CPU_PF_CONF;
 	msr = rdmsr(msrnum);
 	msr.hi |= (0x8 << 5);
 	wrmsr(msrnum, msr);
 
 	/*
-	; Castle performance setting.
-	; Enable Quack for fewer re-RAS on the MC
-	*/
+	   ; Castle performance setting.
+	   ; Enable Quack for fewer re-RAS on the MC
+	 */
 	msrnum = GLIU0_ARB;
 	msr = rdmsr(msrnum);
 	msr.hi &= ~ARB_UPPER_DACK_EN_SET;
@@ -264,7 +248,7 @@
 	msr.hi |= ARB_UPPER_QUACK_EN_SET;
 	wrmsr(msrnum, msr);
 
-	/*	GLIU port active enable, limit south pole masters (AES and PCI) to one outstanding transaction. */
+	/*      GLIU port active enable, limit south pole masters (AES and PCI) to one outstanding transaction. */
 	msrnum = GLIU1_PORT_ACTIVE;
 	msr = rdmsr(msrnum);
 	msr.lo &= ~0x880;
@@ -273,46 +257,45 @@
 	/* Set the Delay Control in GLCP */
 	SetDelayControl();
 
-/*  Enable RSDC*/
+	/*  Enable RSDC */
 	msrnum = CPU_AC_SMM_CTL;
 	msr = rdmsr(msrnum);
 	msr.lo |= SMM_INST_EN_SET;
-		wrmsr(msrnum, msr);
+	wrmsr(msrnum, msr);
 
-
 	/* FPU imprecise exceptions bit */
-		msrnum = CPU_FPU_MSR_MODE;
-		msr = rdmsr(msrnum);
-		msr.lo |= FPU_IE_SET;
-		wrmsr(msrnum, msr);
+	msrnum = CPU_FPU_MSR_MODE;
+	msr = rdmsr(msrnum);
+	msr.lo |= FPU_IE_SET;
+	wrmsr(msrnum, msr);
 
-
 	/* Power Savers (Do after BIST) */
-	/* Enable Suspend on HLT & PAUSE instructions*/
+	/* Enable Suspend on HLT & PAUSE instructions */
 	msrnum = CPU_XC_CONFIG;
-		msr = rdmsr(msrnum);
-	msr.lo |= XC_CONFIG_SUSP_ON_HLT |  XC_CONFIG_SUSP_ON_PAUSE;
-		wrmsr(msrnum, msr);
+	msr = rdmsr(msrnum);
+	msr.lo |= XC_CONFIG_SUSP_ON_HLT | XC_CONFIG_SUSP_ON_PAUSE;
+	wrmsr(msrnum, msr);
 
 	/* Enable SUSP and allow TSC to run in Suspend (keep speed detection happy) */
 	msrnum = CPU_BC_CONF_0;
-		msr = rdmsr(msrnum);
+	msr = rdmsr(msrnum);
 	msr.lo |= TSC_SUSP_SET | SUSP_EN_SET;
 	msr.lo &= 0x0F0FFFFFF;
-	msr.lo |= 0x002000000;	 /* PBZ213: Set PAUSEDLY = 2 */
-		wrmsr(msrnum, msr);
+	msr.lo |= 0x002000000;	/* PBZ213: Set PAUSEDLY = 2 */
+	wrmsr(msrnum, msr);
 
-	/* Disable the debug clock to save power.*/
+	/* Disable the debug clock to save power. */
 	/* NOTE: leave it enabled for fs2 debug */
-/*	msrnum = GLCP_DBGCLKCTL;
+#if 0
+	msrnum = GLCP_DBGCLKCTL;
 	msr.hi = 0;
 	msr.lo = 0;
 	wrmsr(msrnum, msr);
-*/
+#endif
 
 	/* Setup throttling delays to proper mode if it is ever enabled. */
 	msrnum = GLCP_TH_OD;
 	msr.hi = 0;
 	msr.lo = 0x00000603C;
-		wrmsr(msrnum, msr);
-	}
+	wrmsr(msrnum, msr);
+}

Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_lx/model_lx_init.c
===================================================================
--- trunk/LinuxBIOSv2/src/cpu/amd/model_lx/model_lx_init.c	2007-05-10 18:16:03 UTC (rev 2649)
+++ trunk/LinuxBIOSv2/src/cpu/amd/model_lx/model_lx_init.c	2007-05-10 18:32:28 UTC (rev 2650)
@@ -33,12 +33,9 @@
 
 static void vsm_end_post_smi(void)
 {
-	__asm__ volatile (
-			  "push %ax\n"
+	__asm__ volatile ("push %ax\n"
 			  "mov $0x5000, %ax\n"
-			  ".byte 0x0f, 0x38\n"
-			  "pop %ax\n"
-			  );
+			  ".byte 0x0f, 0x38\n" "pop %ax\n");
 }
 
 static void model_lx_init(device_t dev)
@@ -55,23 +52,23 @@
 	vsm_end_post_smi();
 
 	// Set gate A20 (legacy vsm disables it in late init)
-	printk_debug("A20 (0x92): %d\n",inb(0x92));
-	outb(0x02,0x92);
-	printk_debug("A20 (0x92): %d\n",inb(0x92));
+	printk_debug("A20 (0x92): %d\n", inb(0x92));
+	outb(0x02, 0x92);
+	printk_debug("A20 (0x92): %d\n", inb(0x92));
 
 	printk_debug("CPU model_lx_init DONE\n");
 };
 
 static struct device_operations cpu_dev_ops = {
-	.init	= model_lx_init,
+	.init = model_lx_init,
 };
 
 static struct cpu_device_id cpu_table[] = {
-	{ X86_VENDOR_AMD, 0x05A2 },
-	{ 0, 0 },
+	{X86_VENDOR_AMD, 0x05A2},
+	{0, 0},
 };
 
 static struct cpu_driver driver __cpu_driver = {
-	.ops	  = &cpu_dev_ops,
+	.ops = &cpu_dev_ops,
 	.id_table = cpu_table,
 };

Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_lx/syspreinit.c
===================================================================
--- trunk/LinuxBIOSv2/src/cpu/amd/model_lx/syspreinit.c	2007-05-10 18:16:03 UTC (rev 2649)
+++ trunk/LinuxBIOSv2/src/cpu/amd/model_lx/syspreinit.c	2007-05-10 18:32:28 UTC (rev 2650)
@@ -29,14 +29,14 @@
 /* *	Destroys: Al,*/
 /* **/
 /* ***************************************************************************/
-void
-StartTimer1(void){
+void StartTimer1(void)
+{
 	outb(0x56, 0x43);
 	outb(0x12, 0x41);
 }
 
-void
-SystemPreInit(void){
+void SystemPreInit(void)
+{
 
 	/* they want a jump ... */
 #ifndef USE_DCACHE_RAM

Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_lx/vsmsetup.c
===================================================================
--- trunk/LinuxBIOSv2/src/cpu/amd/model_lx/vsmsetup.c	2007-05-10 18:16:03 UTC (rev 2649)
+++ trunk/LinuxBIOSv2/src/cpu/amd/model_lx/vsmsetup.c	2007-05-10 18:32:28 UTC (rev 2650)
@@ -69,13 +69,13 @@
  *  software, even if advised of the possibility of such damage.
  *
  *  $Id: vsmsetup.c,v 1.8 2006/09/08 12:47:57 andrei Exp $
-*
-* Copyright (C) 2007 Advanced Micro Devices
-*
+ *
+ * Copyright (C) 2007 Advanced Micro Devices
+ *
  *--------------------------------------------------------------------*/
 
-/* Modified to be a self sufficient plug in so that it can be used 
-   without reliance on other parts of core Linuxbios 
+/* Modified to be a self sufficient plug in so that it can be used
+   without reliance on other parts of core Linuxbios
    (C) 2005 Nick.Barker9 at btinternet.com
 
   Used initially for epia-m where there are problems getting the bios
@@ -84,96 +84,83 @@
 
 /* Declare a temporary global descriptor table - necessary because the
    Core part of the bios no longer sets up any 16 bit segments */
-__asm__ (
-	/* pointer to original gdt */
-	"gdtarg:			\n"
-	"	.word	gdt_limit	\n"
-	"	.long	gdt	       	\n"		
-
-	/* compute the table limit */
-	"__mygdt_limit = __mygdt_end - __mygdt - 1	\n"
-
-	"__mygdtaddr:			\n"
-	"	.word	__mygdt_limit  	\n"
-	"	.long	__mygdt	       	\n"
-
-	"__mygdt: 		       	\n"
-	/* selgdt 0, unused */
-	"	.word	0x0000, 0x0000	\n"
-	"	.byte	0x00, 0x00, 0x00, 0x00	\n"
-
-	/* selgdt 8, unused */
-	"	.word	0x0000, 0x0000	       	\n"
-	"	.byte	0x00, 0x00, 0x00, 0x00	\n"
-
-	/* selgdt 0x10, flat code segment */
-	"	.word	0xffff, 0x0000	       	\n"
-	"	.byte	0x00, 0x9b, 0xcf, 0x00	\n"	
-
-	/* selgdt 0x18, flat data segment */
-	"	.word	0xffff, 0x0000	       	\n"
-	"	.byte	0x00, 0x93, 0xcf, 0x00	\n"
-
-	/* selgdt 0x20, unused */
-	"	.word	0x0000, 0x0000	       	\n"
-	"	.byte	0x00, 0x00, 0x00, 0x00	\n"
-
-        /* selgdt 0x28 16-bit 64k code at 0x00000000 */
-	"	.word	0xffff, 0x0000	       	\n"
-	"	.byte	0, 0x9a, 0, 0	       	\n"
-
-	/* selgdt 0x30 16-bit 64k data at 0x00000000 */
-	"	.word	0xffff, 0x0000	       	\n"
-	"	.byte	0, 0x92, 0, 0	       	\n"
-
-	"__mygdt_end:				\n"
+__asm__(
+       /* pointer to original gdt */
+       "gdtarg:			\n"
+       "	.word	gdt_limit	\n"
+       "	.long	gdt	       	\n"
+       /* compute the table limit */
+       "__mygdt_limit = __mygdt_end - __mygdt - 1	\n"
+       "__mygdtaddr:			\n"
+       "	.word	__mygdt_limit  	\n"
+       "	.long	__mygdt	       	\n"
+       "__mygdt: 		       	\n"
+       /* selgdt 0, unused */
+       "	.word	0x0000, 0x0000	\n"
+       "	.byte	0x00, 0x00, 0x00, 0x00	\n"
+       /* selgdt 8, unused */
+       "	.word	0x0000, 0x0000	       	\n"
+       "	.byte	0x00, 0x00, 0x00, 0x00	\n"
+       /* selgdt 0x10, flat code segment */
+       "	.word	0xffff, 0x0000	       	\n"
+       "	.byte	0x00, 0x9b, 0xcf, 0x00	\n"
+       /* selgdt 0x18, flat data segment */
+       "	.word	0xffff, 0x0000	       	\n"
+       "	.byte	0x00, 0x93, 0xcf, 0x00	\n"
+       /* selgdt 0x20, unused */
+       "	.word	0x0000, 0x0000	       	\n"
+       "	.byte	0x00, 0x00, 0x00, 0x00	\n"
+       /* selgdt 0x28 16-bit 64k code at 0x00000000 */
+       "	.word	0xffff, 0x0000	       	\n"
+       "	.byte	0, 0x9a, 0, 0	       	\n"
+       /* selgdt 0x30 16-bit 64k data at 0x00000000 */
+       "	.word	0xffff, 0x0000	       	\n"
+       "	.byte	0, 0x92, 0, 0	       	\n"
+       "__mygdt_end:				\n"
 );
 
 /* Declare a pointer to where our idt is going to be i.e. at mem zero */
-__asm__ ("__myidt:		\n"
-	 /* 16-bit limit */
-	 "	.word 1023	\n"
-	 /* 24-bit base */
-	 "	.long 0		\n"
-	 "	.word 0		\n"
+__asm__(
+	"__myidt:		\n"
+	/* 16-bit limit */
+	"	.word 1023	\n"
+	/* 24-bit base */
+	"	.long 0		\n" 
+	"	.word 0		\n"
 );
 
-/* The address arguments to this function are PHYSICAL ADDRESSES */ 
+/* The address arguments to this function are PHYSICAL ADDRESSES */
 static void real_mode_switch_call_vsm(unsigned long smm, unsigned long sysm)
 {
 	uint16_t entryHi = (VSA2_ENTRY_POINT & 0xffff0000) >> 4;
 	uint16_t entryLo = (VSA2_ENTRY_POINT & 0xffff);
 
-	__asm__ __volatile__ (
-		// paranoia -- does ecx get saved? not sure. This is 
+	__asm__ __volatile__(
+		// paranoia -- does ecx get saved? not sure. This is
 		// the easiest safe thing to do.
 		"	pushal			\n"
 		/* save the stack */
 		"	mov 	%%esp, __stack	\n"
 		"	jmp 	1f		\n"
-		"__stack: .long 0		\n"
-		"1:\n"
+		"__stack: .long 0		\n" "1:\n"
 		/* get devfn into %%ecx */
 		"	movl    %%esp, %%ebp	\n"
 #if 0
-		/* I'm not happy about that pushal followed by esp-relative references. 
-		  * just do hard-codes for now
-		  */
+		/* I'm not happy about that pushal followed by esp-relative
+		 * references. Just do hard-codes for now
+		 */
 		"	movl    8(%%ebp), %%ecx	\n"
 		"	movl    12(%%ebp), %%edx	\n"
 #endif
 		"	movl    %0, %%ecx	\n"
 		"	movl    %1, %%edx	\n"
-
 		/* load 'our' gdt */
 		"	lgdt	%%cs:__mygdtaddr	\n"
-
 		/*  This configures CS properly for real mode. */
 		"	ljmp	$0x28, $__rms_16bit\n"
 		"__rms_16bit:		  	\n"
 		"	.code16			\n"
 		/* 16 bit code from here on... */
-
 		/* Load the segment registers w/ properly configured segment
 		 * descriptors.  They will retain these configurations (limits,
 		 * writability, etc.) once protected mode is turned off. */
@@ -183,73 +170,67 @@
 		"	mov	%%ax, %%fs       	\n"
 		"	mov	%%ax, %%gs       	\n"
 		"	mov	%%ax, %%ss       	\n"
-
 		/* Turn off protection (bit 0 in CR0) */
 		"	movl	%%cr0, %%eax	\n"
 		"	andl	$0xFFFFFFFE, %%eax \n"
 		"	movl	%%eax, %%cr0	\n"
-
 		/* Now really going into real mode */
 		"	ljmp	$0,  $__rms_real\n"
 		"__rms_real:			\n"
 
-		/* put the stack at the end of page zero. 
-		 * that way we can easily share it between real and protected, 
-		 * since the 16-bit ESP at segment 0 will work for any case. */
+		/* put the stack at the end of page zero.
+		 * that way we can easily share it between real and protected,
+		 * since the 16-bit ESP at segment 0 will work for any case. 
+		 */
+
 		/* Setup a stack */
 		"	mov	$0x0, %%ax	\n"
 		"	mov	%%ax, %%ss	\n"
 		"	movl	$0x1000, %%eax	\n"
 		"	movl	%%eax, %%esp	\n"
-
 		/* Load our 16 it idt */
 		"	xor	%%ax, %%ax	\n"
 		"	mov	%%ax, %%ds	\n"
 		"	lidt	__myidt		\n"
-
 		/* Dump zeros in the other segregs */
-		"	mov	%%ax, %%es       	\n"
+		"	mov	%%ax, %%es     	\n"
 		/* FixMe: Big real mode for gs, fs? */
-		"	mov	%%ax, %%fs       	\n"
-		"	mov	%%ax, %%gs       	\n"
+		"	mov	%%ax, %%fs     	\n"
+		"	mov	%%ax, %%gs     	\n"
 		"	mov	$0x40, %%ax	\n"
 		"	mov	%%ax, %%ds	\n"
-		//"	mov	%%cx, %%ax	\n"
+		//"     mov     %%cx, %%ax      \n"
 		"	movl    %0, %%ecx	\n"
 		"	movl    %1, %%edx	\n"
-
 		/* call the VSA2 entry point address */
 		"	lcall	%2, %3\n"
-
-		/* if we got here, just about done. 
+		/* if we got here, just about done.
 		 * Need to get back to protected mode */
-		"	movl	%%cr0, %%eax	\n"
-		"	orl	$0x0000001, %%eax\n" /* PE = 1 */
+		"	movl	%%cr0, %%eax	\n" 
+		"	orl	$0x0000001, %%eax\n"	/* PE = 1 */
 		"	movl	%%eax, %%cr0	\n"
-
 		/* Now that we are in protected mode jump to a 32 bit code segment. */
 		"	data32	ljmp	$0x10, $vsmrestart\n"
 		"vsmrestart:\n"
 		"	.code32\n"
-		"	movw	$0x18, %%ax     	\n"
-		"	mov	%%ax, %%ds       	\n"
+		"	movw	$0x18, %%ax    	\n"
+		"	mov	%%ax, %%ds     	\n"
 		"	mov	%%ax, %%es	\n"
 		"	mov	%%ax, %%fs	\n"
 		"	mov	%%ax, %%gs	\n"
 		"	mov	%%ax, %%ss	\n"
-
 		/* restore proper gdt and idt */
 		"	lgdt	%%cs:gdtarg	\n"
 		"	lidt	idtarg		\n"
-
 		".globl vsm_exit		\n"
 		"vsm_exit:			\n"
 		"	mov	__stack, %%esp	\n"
-		"	popal			\n"
-		:: "g" (smm), "g" (sysm), "g" (entryHi), "g" (entryLo));
+		"	popal			\n"::
+		"g" (smm), "g"(sysm), "g"(entryHi), "g"(entryLo)
+	);
 }
 
-__asm__ (".text\n""real_mode_switch_end:\n");
+__asm__(".text\n" "real_mode_switch_end:\n");
 extern char real_mode_switch_end[];
 
 // andrei: some VSA virtual register helpers: raw read and MSR read
@@ -257,36 +238,32 @@
 uint32_t VSA_vrRead(uint16_t classIndex)
 {
 	unsigned eax, ebx, ecx, edx;
-	asm volatile(
+	asm volatile (
+		"movw	$0x0AC1C, %%dx		\n"
+		"orl	$0x0FC530000, %%eax	\n"
+		"outl	%%eax, %%dx		\n"
+		"addb	$2, %%dl		\n"
+		"inw	%%dx, %%ax		\n"
+		: "=a" (eax), "=b"(ebx), "=c"(ecx), "=d"(edx) 
+		: "a"(classIndex)
+	);
 
-		"movw	$0x0AC1C, %%dx			\n"
-		"orl	$0x0FC530000, %%eax		\n"
-		"outl	%%eax, %%dx				\n"
-		"addb	$2, %%dl				\n"
-		"inw	%%dx, %%ax				\n"
-
-		: "=a" (eax), "=b" (ebx), "=c" (ecx), "=d" (edx)
-		: "a" (classIndex)
-		);
-
 	return eax;
 }
 
 uint32_t VSA_msrRead(uint32_t msrAddr)
 {
 	unsigned eax, ebx, ecx, edx;
-	asm volatile(
-
+	asm volatile (
 		"movw	$0x0AC1C, %%dx			\n"
 		"movl	$0x0FC530007, %%eax		\n"
 		"outl	%%eax, %%dx				\n"
 		"addb	$2, %%dl				\n"
 		"inw	%%dx, %%ax				\n"
+		: "=a" (eax), "=b"(ebx), "=c"(ecx), "=d"(edx)
+		: "c"(msrAddr)
+	);
 
-		: "=a" (eax), "=b" (ebx), "=c" (ecx), "=d" (edx)
-		: "c" (msrAddr)
-		);
-
 	return eax;
 }
 
@@ -296,38 +273,33 @@
 	unsigned long busdevfn;
 	unsigned int rom = 0;
 	unsigned char *buf;
-	unsigned int size = SMM_SIZE*1024;
+	unsigned int size = SMM_SIZE * 1024;
 	int i;
-	unsigned long ilen, olen;	
-	
+	unsigned long ilen, olen;
+
 	printk_err("do_vsmbios\n");
 	/* clear vsm bios data area */
 	for (i = 0x400; i < 0x500; i++) {
-		*(volatile unsigned char *) i = 0;
+		*(volatile unsigned char *)i = 0;
 	}
 
 	/* declare rom address here - keep any config data out of the way
 	 * of core LXB stuff */
 
 	/* this is the base of rom on the LX at present. At some point, this has to be
-	  * much better parameterized 
-	  */
-	//rom = 0xfff80000;
-	//rom = 0xfffc0000;
+	 * much better parameterized
+	 */
 	/* the VSA starts at the base of rom - 64 */
 	//rom = ((unsigned long) 0) - (ROM_SIZE  + 64*1024);
-	
-	//rom = 0xfffc8000;
-
 	//VSA is cat onto the end after LB builds
-	rom = ((unsigned long) 0) - (ROM_SIZE + 36 * 1024);
-	buf = (unsigned char *) VSA2_BUFFER;
-	olen = unrv2b((uint8_t *)rom, buf, &ilen);
+	rom = ((unsigned long)0) - (ROM_SIZE + 36 * 1024);
+	buf = (unsigned char *)VSA2_BUFFER;
+	olen = unrv2b((uint8_t *) rom, buf, &ilen);
 	printk_debug("buf ilen %d olen%d\n", ilen, olen);
 	printk_debug("buf %p *buf %d buf[256k] %d\n",
-		     buf, buf[0], buf[SMM_SIZE*1024]);
+		     buf, buf[0], buf[SMM_SIZE * 1024]);
 	printk_debug("buf[0x20] signature is %x:%x:%x:%x\n",
-		     buf[0x20] ,buf[0x21] ,buf[0x22],buf[0x23]);
+		     buf[0x20], buf[0x21], buf[0x22], buf[0x23]);
 	/* check for post code at start of vsainit.bin. If you don't see it,
 	   don't bother. */
 	if ((buf[0x20] != 0xb0) || (buf[0x21] != 0x10) ||
@@ -336,11 +308,6 @@
 		return;
 	}
 
-	//memcpy((void *) VSA2_BUFFER, buf, size);
-
-	//for (i = 0; i < 0x800000; i++)
-	//	outb(0xaa, 0x80);
-
 	/* ecx gets smm, edx gets sysm */
 	printk_err("Call real_mode_switch_call_vsm\n");
 	real_mode_switch_call_vsm(MSR_GLIU0_SMM, MSR_GLIU0_SYSMEM);
@@ -350,38 +317,39 @@
 	outb(0x12, 0x41);
 
 	// check that VSA is running OK
-	if(VSA_vrRead(SIGNATURE) == VSA2_SIGNATURE)
+	if (VSA_vrRead(SIGNATURE) == VSA2_SIGNATURE)
 		printk_debug("do_vsmbios: VSA2 VR signature verified\n");
-	else printk_err("do_vsmbios: VSA2 VR signature not valid, install failed!\n");
+	else
+		printk_err
+		    ("do_vsmbios: VSA2 VR signature not valid, install failed!\n");
 }
 
-
-// we had hoped to avoid this. 
-// this is a stub IDT only. It's main purpose is to ignore calls 
-// to the BIOS. 
+// we had hoped to avoid this.
+// this is a stub IDT only. It's main purpose is to ignore calls
+// to the BIOS.
 // no longer. Dammit. We have to respond to these.
 struct realidt {
 	unsigned short offset, cs;
-}; 
+};
 
 // from a handy writeup that andrey found.
 
-// handler. 
-// There are some assumptions we can make here. 
-// First, the Top Of Stack (TOS) is located on the top of page zero. 
-// we can share this stack between real and protected mode. 
+// handler.
+// There are some assumptions we can make here.
+// First, the Top Of Stack (TOS) is located on the top of page zero.
+// we can share this stack between real and protected mode.
 // that simplifies a lot of things ...
-// we'll just push all the registers on the stack as longwords, 
-// and pop to protected mode. 
-// second, since this only ever runs as part of linuxbios, 
+// we'll just push all the registers on the stack as longwords,
+// and pop to protected mode.
+// second, since this only ever runs as part of linuxbios,
 // we know all the segment register values -- so we don't save any.
-// keep the handler that calls things small. It can do a call to 
+// keep the handler that calls things small. It can do a call to
 // more complex code in linuxbios itself. This helps a lot as we don't
 // have to do address fixup in this little stub, and calls are absolute
 // so the handler is relocatable.
 void handler(void)
 {
-	__asm__ __volatile__ ( 
+	__asm__ __volatile__(
 		"	.code16		\n"
 		"idthandle:		\n"
 		"	pushal		\n"
@@ -389,12 +357,12 @@
 		"	ljmp 	$0, $callbiosint16\n"
 		"end_idthandle:		\n"
 		"	.code32		\n"
-		);
+	);
 }
 
 void debughandler(void)
 {
-	__asm__ __volatile__ ( 
+	__asm__ __volatile__(
 		"	.code16		\n"
 		"debughandle:		\n"
 		"	pushw	%cx	\n"
@@ -403,99 +371,91 @@
 		"	loop	dbh1	\n"
 		"	popw	%cx	\n"
 		"	iret		\n"
-		"end_debughandle:	\n"
+		"end_debughandle:	\n" 
 		".code32		\n"
-		);
+	);
 }
 
 // Calling conventions. The first C function is called with this stuff
 // on the stack. They look like value parameters, but note that if you
-// modify them they will go back to the INTx function modified. 
+// modify them they will go back to the INTx function modified.
 // the C function will call the biosint function with these as
-// REFERENCE parameters. In this way, we can easily get 
+// REFERENCE parameters. In this way, we can easily get
 // returns back to the INTx caller (i.e. vgabios)
 void callbiosint(void)
 {
-	__asm__ __volatile__ (
+	__asm__ __volatile__(
 		"	.code16		\n"
 		"callbiosint16:		\n"
 		"	push	%ds	\n"
 		"	push	%es	\n"
-		"	push	%fs	\n"
-		"	push	%gs	\n"
+		"	push	%fs	\n" "	push	%gs	\n"
 		// clean up the int #. To save space we put it in the lower
-		// byte. But the top 24 bits are junk. 
+		// byte. But the top 24 bits are junk.
 		"	andl	$0xff, %eax\n"
 		// this push does two things:
 		// - put the INT # on the stack as a parameter
 		// - provides us with a temp for the %cr0 mods.
-		"	pushl	%eax	\n"
-		"	movb	$0xbb, %al\n"
-		"	outb	%al, $0x80\n"
-		"	movl    %cr0, %eax\n"
-		"	orl	$0x00000001, %eax\n" /* PE = 1 */
+		"	pushl	%eax	\n" 
+		"	movb	$0xbb, %al\n" 
+		"	outb	%al, $0x80\n" 
+		"	movl    %cr0, %eax\n" 
+		"	orl	$0x00000001, %eax\n"	/* PE = 1 */
 		"	movl	%eax, %cr0\n"
 		/* Now that we are in protected mode jump to a 32 bit code segment. */
 		"	data32  ljmp    $0x10, $biosprotect\n"
 		"biosprotect:		\n"
 		"	.code32		\n"
-		"	movw	$0x18, %ax          \n"
-		"	mov	%ax, %ds          \n"
-		"	mov	%ax, %es          \n"
-		"	mov	%ax, %fs          \n"
-		"	mov	%ax, %gs          \n"
-		"	mov	%ax, %ss          \n"
-		"	lidt	idtarg         	\n"
-		"	call	biosint		\n"
+		"	movw	$0x18, %ax\n"
+		"	mov	%ax, %ds\n"
+		"	mov	%ax, %es\n"
+		"	mov	%ax, %fs\n"
+		"	mov	%ax, %gs\n"
+		"	mov	%ax, %ss\n"
+		"	lidt	idtarg  \n"
+		"	call	biosint	\n"
 		// back to real mode ...
 		"	ljmp	$0x28, $__rms_16bit2\n"
-		"__rms_16bit2:			\n"
-		"	.code16			\n"
+		"__rms_16bit2:		\n"
+		"	.code16		\n"
 		/* 16 bit code from here on... */
 		/* Load the segment registers w/ properly configured segment
 		 * descriptors.  They will retain these configurations (limits,
 		 * writability, etc.) once protected mode is turned off. */
-		"	mov	$0x30, %ax	\n"
-		"	mov	%ax, %ds	\n"
-		"	mov	%ax, %es	\n"
-		"	mov	%ax, %fs	\n"
-		"	mov	%ax, %gs	\n"
-		"	mov	%ax, %ss	\n"
-		
+		"	mov	$0x30, %ax\n"
+		"	mov	%ax, %ds\n"
+		"	mov	%ax, %es\n"
+		"	mov	%ax, %fs\n"
+		"	mov	%ax, %gs\n"
+		"	mov	%ax, %ss\n"
 		/* Turn off protection (bit 0 in CR0) */
 		"	movl	%cr0, %eax		\n"
 		"	andl	$0xFFFFFFFE, %eax	\n"
 		"	movl	%eax, %cr0		\n"
-
 		/* Now really going into real mode */
 		"	ljmp $0,  $__rms_real2	\n"
 		"__rms_real2:			\n"
-
 		/* Setup a stack
 		 * FixME: where is esp? */
-		/* no need for a fix here. The esp is shared from 32-bit and 16-bit mode. 
-		  * you have to hack on the ss, but the esp remains the same across 
-		  * modes. 
-		  */
+		/* no need for a fix here. The esp is shared from 32-bit and 16-bit mode.
+		 * you have to hack on the ss, but the esp remains the same across
+		 * modes.
+		 */
 		"	mov	$0x0, %ax       \n"
 		"	mov	%ax, %ss	\n"
-
 		/* debugging for RGM */
 		"	mov	$0x11, %al	\n"
 		"	outb	%al, $0x80	\n"
-
 		/* Load our 16 bit idt */
 		"	xor	%ax, %ax	\n"
 		"	mov	%ax, %ds	\n"
 		"	lidt	__myidt		\n"
-
 		/* Dump zeros in the other segregs */
 		"	mov	%ax, %es	\n"
 		"	mov	%ax, %fs	\n"
 		"	mov	%ax, %gs	\n"
 		"	mov	$0x40, %ax	\n"
 		"	mov	%ax, %ds	\n"
-
 		/* pop the INT # that you pushed earlier */
 		"	popl	%eax		\n"
 		"	pop	%gs		\n"
@@ -504,12 +464,11 @@
 		"	pop	%ds		\n"
 		"	popal			\n"
 		"	iret			\n"
-		"	.code32			\n"
-		);
+		"	.code32			\n");
 }
 
 enum {
-	PCIBIOS = 0x1a, 
+	PCIBIOS = 0x1a,
 	MEMSIZE = 0x12
 };
 
@@ -519,29 +478,29 @@
 
 int handleint21(unsigned long *pedi, unsigned long *pesi, unsigned long *pebp,
 		unsigned long *pesp, unsigned long *pebx, unsigned long *pedx,
-		unsigned long *pecx, unsigned long *peax, unsigned long *pflags
-        );
+		unsigned long *pecx, unsigned long *peax,
+		unsigned long *pflags);
 
 int biosint(unsigned long intnumber,
 	    unsigned long gsfs, unsigned long dses,
 	    unsigned long edi, unsigned long esi,
-	    unsigned long ebp, unsigned long esp, 
-	    unsigned long ebx, unsigned long edx, 
-	    unsigned long ecx, unsigned long eax, 
+	    unsigned long ebp, unsigned long esp,
+	    unsigned long ebx, unsigned long edx,
+	    unsigned long ecx, unsigned long eax,
 	    unsigned long cs_ip, unsigned short stackflags)
 {
-	unsigned long ip; 
-	unsigned long cs; 
+	unsigned long ip;
+	unsigned long cs;
 	unsigned long flags;
 	int ret = -1;
 
 	ip = cs_ip & 0xffff;
 	cs = cs_ip >> 16;
 	flags = stackflags;
-	
+
 	printk_debug("biosint: INT# 0x%lx\n", intnumber);
-	printk_debug("biosint: eax 0x%lx ebx 0x%lx ecx 0x%lx edx 0x%lx\n", 
-		      eax, ebx, ecx, edx);
+	printk_debug("biosint: eax 0x%lx ebx 0x%lx ecx 0x%lx edx 0x%lx\n",
+		     eax, ebx, ecx, edx);
 	printk_debug("biosint: ebp 0x%lx esp 0x%lx edi 0x%lx esi 0x%lx\n",
 		     ebp, esp, edi, esi);
 	printk_debug("biosint:  ip 0x%x   cs 0x%x  flags 0x%x\n",
@@ -549,15 +508,15 @@
 	printk_debug("biosint: gs 0x%x fs 0x%x ds 0x%x es 0x%x\n",
 		     gsfs >> 16, gsfs & 0xffff, dses >> 16, dses & 0xffff);
 
-	// cases in a good compiler are just as good as your own tables. 
+	// cases in a good compiler are just as good as your own tables.
 	switch (intnumber) {
-	case 0 ... 15:
+	case 0...15:
 		// These are not BIOS service, but the CPU-generated exceptions
 		printk_info("biosint: Oops, exception %u\n", intnumber);
 		if (esp < 0x1000) {
 			printk_debug("Stack contents: ");
 			while (esp < 0x1000) {
-				printk_debug("0x%04x ", *(unsigned short *) esp);
+				printk_debug("0x%04x ", *(unsigned short *)esp);
 				esp += 2;
 			}
 			printk_debug("\n");
@@ -566,82 +525,78 @@
 		// "longjmp"
 		//vga_exit();
 		break;
-		
+
 	case PCIBIOS:
-		ret = pcibios( &edi, &esi, &ebp, &esp, 
-			       &ebx, &edx, &ecx, &eax, &flags);
+		ret = pcibios(&edi, &esi, &ebp, &esp,
+			      &ebx, &edx, &ecx, &eax, &flags);
 		break;
-	case MEMSIZE: 
-		// who cares. 
+	case MEMSIZE:
+		// who cares.
 		eax = 128 * 1024;
 		ret = 0;
 		break;
 	case 0x15:
-		ret=handleint21( &edi, &esi, &ebp, &esp, 
-				&ebx, &edx, &ecx, &eax, &flags);
+		ret = handleint21(&edi, &esi, &ebp, &esp,
+				  &ebx, &edx, &ecx, &eax, &flags);
 		break;
 	default:
-		printk_info("BIOSINT: Unsupport int #0x%x\n", 
-			    intnumber);
+		printk_info("BIOSINT: Unsupport int #0x%x\n", intnumber);
 		break;
 	}
 	if (ret)
-		flags |= 1; // carry flags
+		flags |= 1;	// carry flags
 	else
 		flags &= ~1;
 	stackflags = flags;
 	return ret;
-} 
+}
 
-
-void setup_realmode_idt(void) 
+void setup_realmode_idt(void)
 {
 	extern unsigned char idthandle, end_idthandle;
 	extern unsigned char debughandle, end_debughandle;
 
 	int i;
-	struct realidt *idts = (struct realidt *) 0;
+	struct realidt *idts = (struct realidt *)0;
 	int codesize = &end_idthandle - &idthandle;
 	unsigned char *intbyte, *codeptr;
-	
+
 	// for each int, we create a customized little handler
-	// that just pushes %ax, puts the int # in %al, 
-	// then calls the common interrupt handler. 
-	// this necessitated because intel didn't know much about 
+	// that just pushes %ax, puts the int # in %al,
+	// then calls the common interrupt handler.
+	// this necessitated because intel didn't know much about
 	// architecture when they did the 8086 (it shows)
 	// (hmm do they know anymore even now :-)
-	// obviously you can see I don't really care about memory 
+	// obviously you can see I don't really care about memory
 	// efficiency. If I did I would probe back through the stack
 	// and get it that way. But that's really disgusting.
 	for (i = 0; i < 256; i++) {
 		idts[i].cs = 0;
-		codeptr = (unsigned char*) 4096 + i * codesize;
-		idts[i].offset = (unsigned) codeptr;
+		codeptr = (unsigned char *)4096 + i * codesize;
+		idts[i].offset = (unsigned)codeptr;
 		memcpy(codeptr, &idthandle, codesize);
 		intbyte = codeptr + 3;
 		*intbyte = i;
 	}
-	
+
 	// fixed entry points
-	
+
 	// VGA BIOSes tend to hardcode f000:f065 as the previous handler of
-	// int10. 
+	// int10.
 	// calling convention here is the same as INTs, we can reuse
 	// the int entry code.
-	codeptr = (unsigned char*) 0xff065;
+	codeptr = (unsigned char *)0xff065;
 	memcpy(codeptr, &idthandle, codesize);
 	intbyte = codeptr + 3;
-	*intbyte = 0x42; /* int42 is the relocated int10 */
+	*intbyte = 0x42;	/* int42 is the relocated int10 */
 
 	/* debug handler - useful to set a programmable delay between instructions if the
 	   TF bit is set upon call to real mode */
 	idts[1].cs = 0;
 	idts[1].offset = 16384;
-	memcpy((void*)16384, &debughandle, &end_debughandle - &debughandle);
+	memcpy((void *)16384, &debughandle, &end_debughandle - &debughandle);
 }
 
-
-
 enum {
 	CHECK = 0xb001,
 	FINDDEV = 0xb102,
@@ -654,15 +609,15 @@
 };
 
 // errors go in AH. Just set these up so that word assigns
-// will work. KISS. 
+// will work. KISS.
 enum {
 	PCIBIOS_NODEV = 0x8600,
 	PCIBIOS_BADREG = 0x8700
 };
 
 int
-pcibios(unsigned long *pedi, unsigned long *pesi, unsigned long *pebp, 
-	unsigned long *pesp, unsigned long *pebx, unsigned long *pedx, 
+pcibios(unsigned long *pedi, unsigned long *pesi, unsigned long *pebp,
+	unsigned long *pesp, unsigned long *pebx, unsigned long *pedx,
 	unsigned long *pecx, unsigned long *peax, unsigned long *pflags)
 {
 	unsigned long edi = *pedi;
@@ -674,150 +629,153 @@
 	unsigned long ecx = *pecx;
 	unsigned long eax = *peax;
 	unsigned long flags = *pflags;
-	unsigned short func = (unsigned short) eax;
+	unsigned short func = (unsigned short)eax;
 	int retval = 0;
 	unsigned short devid, vendorid, devfn;
-	short devindex; /* Use short to get rid of gabage in upper half of 32-bit register */
+	short devindex;		/* Use short to get rid of gabage in upper half of 32-bit register */
 	unsigned char bus;
 	device_t dev;
-	
-	switch(func) {
-	case  CHECK:
+
+	switch (func) {
+	case CHECK:
 		*pedx = 0x4350;
 		*pecx = 0x2049;
 		retval = 0;
 		break;
 	case FINDDEV:
-	{
-		devid = *pecx;
-		vendorid = *pedx;
-		devindex = *pesi;
-		dev = 0;
-		while ((dev = dev_find_device(vendorid, devid, dev))) {
-			if (devindex <= 0)
-				break;
-			devindex--;
+		{
+			devid = *pecx;
+			vendorid = *pedx;
+			devindex = *pesi;
+			dev = 0;
+			while ((dev = dev_find_device(vendorid, devid, dev))) {
+				if (devindex <= 0)
+					break;
+				devindex--;
+			}
+			if (dev) {
+				unsigned short busdevfn;
+				*peax = 0;
+				// busnum is an unsigned char;
+				// devfn is an int, so we mask it off.
+				busdevfn = (dev->bus->secondary << 8)
+				    | (dev->path.u.pci.devfn & 0xff);
+				printk_debug("0x%x: return 0x%x\n", func,
+					     busdevfn);
+				*pebx = busdevfn;
+				retval = 0;
+			} else {
+				*peax = PCIBIOS_NODEV;
+				retval = -1;
+			}
 		}
-		if (dev) {
-			unsigned short busdevfn;
-			*peax = 0;
-			// busnum is an unsigned char;
-			// devfn is an int, so we mask it off. 
-			busdevfn = (dev->bus->secondary << 8)
-				| (dev->path.u.pci.devfn & 0xff);
-			printk_debug("0x%x: return 0x%x\n", func, busdevfn);
-			*pebx = busdevfn;
-			retval = 0;
-		} else {
-			*peax = PCIBIOS_NODEV;
-			retval = -1;
-		}
-	}
-	break;
+		break;
 	case READCONFDWORD:
 	case READCONFWORD:
 	case READCONFBYTE:
 	case WRITECONFDWORD:
 	case WRITECONFWORD:
 	case WRITECONFBYTE:
-	{
-		unsigned long dword;
-		unsigned short word;
-		unsigned char byte;
-		unsigned char reg;
-		
-		devfn = *pebx & 0xff;
-		bus = *pebx >> 8;
-		reg = *pedi;
-		dev = dev_find_slot(bus, devfn);
-		if (! dev) {
-			printk_debug("0x%x: BAD DEVICE bus %d devfn 0x%x\n", func, bus, devfn);
-			// idiots. the pcibios guys assumed you'd never pass a bad bus/devfn!
-			*peax = PCIBIOS_BADREG;
-			retval = -1;
-		}
-		switch(func) {
-		case READCONFBYTE:
-			byte = pci_read_config8(dev, reg);
-			*pecx = byte;
-			break;
-		case READCONFWORD:
-			word = pci_read_config16(dev, reg);
-			*pecx = word;
-			break;
-		case READCONFDWORD:
-			dword = pci_read_config32(dev, reg);
-			*pecx = dword;
-			break;
-		case WRITECONFBYTE:
-			byte = *pecx;
-			pci_write_config8(dev, reg, byte);
-			break;
-		case WRITECONFWORD:
-			word = *pecx;
-			pci_write_config16(dev, reg, word);
-			break;
-		case WRITECONFDWORD:
-			dword = *pecx;
-			pci_write_config32(dev, reg, dword);
-			break;
-		}
-		
-		if (retval) 
-			retval = PCIBIOS_BADREG;
-		printk_debug("0x%x: bus %d devfn 0x%x reg 0x%x val 0x%lx\n",
+		{
+			unsigned long dword;
+			unsigned short word;
+			unsigned char byte;
+			unsigned char reg;
+
+			devfn = *pebx & 0xff;
+			bus = *pebx >> 8;
+			reg = *pedi;
+			dev = dev_find_slot(bus, devfn);
+			if (!dev) {
+				printk_debug
+				    ("0x%x: BAD DEVICE bus %d devfn 0x%x\n",
+				     func, bus, devfn);
+				// idiots. the pcibios guys assumed you'd never pass a bad bus/devfn!
+				*peax = PCIBIOS_BADREG;
+				retval = -1;
+			}
+			switch (func) {
+			case READCONFBYTE:
+				byte = pci_read_config8(dev, reg);
+				*pecx = byte;
+				break;
+			case READCONFWORD:
+				word = pci_read_config16(dev, reg);
+				*pecx = word;
+				break;
+			case READCONFDWORD:
+				dword = pci_read_config32(dev, reg);
+				*pecx = dword;
+				break;
+			case WRITECONFBYTE:
+				byte = *pecx;
+				pci_write_config8(dev, reg, byte);
+				break;
+			case WRITECONFWORD:
+				word = *pecx;
+				pci_write_config16(dev, reg, word);
+				break;
+			case WRITECONFDWORD:
+				dword = *pecx;
+				pci_write_config32(dev, reg, dword);
+				break;
+			}
+
+			if (retval)
+				retval = PCIBIOS_BADREG;
+			printk_debug
+			    ("0x%x: bus %d devfn 0x%x reg 0x%x val 0x%lx\n",
 			     func, bus, devfn, reg, *pecx);
-		*peax = 0;
-		retval = 0;
-	}
-	break;
+			*peax = 0;
+			retval = 0;
+		}
+		break;
 	default:
-		printk_err("UNSUPPORTED PCIBIOS FUNCTION 0x%x\n",  func);
+		printk_err("UNSUPPORTED PCIBIOS FUNCTION 0x%x\n", func);
 		break;
 	}
-	
+
 	return retval;
-} 
+}
 
 int handleint21(unsigned long *edi, unsigned long *esi, unsigned long *ebp,
 		unsigned long *esp, unsigned long *ebx, unsigned long *edx,
 		unsigned long *ecx, unsigned long *eax, unsigned long *flags)
 {
-	int res=-1;
+	int res = -1;
 	printk_debug("handleint21, eax 0x%x\n", *eax);
-	switch(*eax&0xffff)
-	{
+	switch (*eax & 0xffff) {
 	case 0x5f19:
 		break;
 	case 0x5f18:
-		*eax=0x5f;
-		*ebx=0x545; // MCLK = 133, 32M frame buffer, 256 M main memory
-		*ecx=0x060;
-		res=0;
+		*eax = 0x5f;
+		*ebx = 0x545;	// MCLK = 133, 32M frame buffer, 256 M main memory
+		*ecx = 0x060;
+		res = 0;
 		break;
 	case 0x5f00:
 		*eax = 0x8600;
 		break;
 	case 0x5f01:
 		*eax = 0x5f;
-		*ecx = (*ecx & 0xffffff00 ) | 2; // panel type =  2 = 1024 * 768
+		*ecx = (*ecx & 0xffffff00) | 2;	// panel type =  2 = 1024 * 768
 		res = 0;
 		break;
 	case 0x5f02:
-		*eax=0x5f;
-		*ebx= (*ebx & 0xffff0000) | 2;
-		*ecx= (*ecx & 0xffff0000) | 0x401;  // PAL + crt only 
-		*edx= (*edx & 0xffff0000) | 0;  // TV Layout - default
-		res=0;
+		*eax = 0x5f;
+		*ebx = (*ebx & 0xffff0000) | 2;
+		*ecx = (*ecx & 0xffff0000) | 0x401;	// PAL + crt only
+		*edx = (*edx & 0xffff0000) | 0;	// TV Layout - default
+		res = 0;
 		break;
 	case 0x5f0f:
-		*eax=0x860f;
+		*eax = 0x860f;
 		break;
 	case 0xBEA7:
-		*eax=66;
+		*eax = 66;
 		break;
 	case 0xBEA4:
-		*eax=500;
+		*eax = 500;
 		break;
 	}
 	return res;





More information about the coreboot mailing list