[LinuxBIOS] [PATCH] adm1027.c fan control

yhlu yinghailu at gmail.com
Mon May 14 18:54:48 CEST 2007


On 5/14/07, Marc Jones <marc.jones at amd.com> wrote:
>
>
> Ward Vandewege wrote:
> >>> I'll work on moving the code to mainboard.c file.
> >> Does it make sense to have an API letting the mainboard specific code
> >> interface the component? Maybe even setting the FANs and threshold in
> >> the config.lb file?
> >
> > I think that could be very helpful. What kind of syntax do you have in mind?
> >
> > It could potentially get a bit complicated; the Tyan s2881 for instance has 2
> > different HWM chips, each driving a number of fans and hooked up to different
> > temperature sensors.
> >
> > Thanks,
> > Ward.
> >
>
> I agree with Ward. Config.lb is complicated enough. I would rather see a
>   user setup function that gets called from mainboard.c with the
> appropriate thresholds.

OK, ward could work on put that on mainboard.c at first. and late
someone could optimize it ..

YH




More information about the coreboot mailing list