[LinuxBIOS] r2670 - in trunk/LinuxBIOSv2/src/mainboard: asus/p2b bitworks/ims densitron/dpx114 via/epia via/epia-m

[roger]

On Tue, 2007-05-15 at 18:00 +0200, Stefan Reinauer wrote:
> * Uwe Hermann <uwe at hermann-uwe.de> [070515 17:46]:
> > On Tue, May 15, 2007 at 12:28:55PM +0200, Peter Stuge wrote:
> > > On Tue, May 15, 2007 at 10:26:54AM +0000, svn at openbios.org wrote:
> > > >  static inline int spd_read_byte(unsigned device, unsigned address)
> > > >  {
> > > > -	uint8_t c;
> > > > -	c = smbus_read_byte(device, address);
> > > > -	return c;
> > > > +	return smbus_read_byte(device, address);
> > > 
> > > Should they return uint8_t perhaps?
> > 
> > Yes, I think so. AFAIK smbus works with byte values (or at least
> > smbus_read_byte() does), and SPD data consists of bytes, too...
> 
> Most other romcc functions have no sized variables, but just
> signed/unsigned. 
> 
> I would assume spd_read_byte should be at least unsigned though. 
> 
> Can anyone confirm romcc creates different code if you choose uint8_t or
> unsigned or unsigned int as a return type?
> 
> Stefan

Just posted to the list on this question, confirming i get a hang
without the above fix for asus/p2b/auto.c on generic DFI P2XBL board.

--
Roger
http://www.eskimo.com/~roger/index.html
Key fingerprint = 8977 A252 2623 F567 70CD 1261 640F C963 1005 1D61

Tue May 15 09:31:20 PDT 2007