[LinuxBIOS] r2675 - trunk/LinuxBIOSv2/src/mainboard/tyan/s2881
svn at openbios.org
svn at openbios.org
Sat May 19 19:28:40 CEST 2007
Author: uwe
Date: 2007-05-19 19:28:40 +0200 (Sat, 19 May 2007)
New Revision: 2675
Modified:
trunk/LinuxBIOSv2/src/mainboard/tyan/s2881/mainboard.c
Log:
Minor cosmetics (trivial).
Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
Modified: trunk/LinuxBIOSv2/src/mainboard/tyan/s2881/mainboard.c
===================================================================
--- trunk/LinuxBIOSv2/src/mainboard/tyan/s2881/mainboard.c 2007-05-19 16:07:08 UTC (rev 2674)
+++ trunk/LinuxBIOSv2/src/mainboard/tyan/s2881/mainboard.c 2007-05-19 17:28:40 UTC (rev 2675)
@@ -26,7 +26,8 @@
#include <device/smbus.h>
/**
- * Do some s2881-specific HWM initialization for the ADT7463 chip
+ * Do some S2881-specific HWM initialization for the ADT7463 chip.
+ *
* See Analog Devices ADT7463 datasheet, Rev C (2004):
* http://www.analog.com/en/prod/0,,766_825_ADT7463,00.html
*/
@@ -38,61 +39,64 @@
int result;
- /* Find the smbus controller (amd-8111) */
+ /* Find the SMBus controller (AMD-8111). */
smbus_dev = dev_find_device(0x1022, 0x746b, 0);
if (!smbus_dev) {
- die("SMBUS controller not found\n");
+ die("SMBus controller not found\n");
}
- printk_debug("smbus controller found\n");
+ printk_debug("SMBus controller found\n");
- /* Find the adt7463 device */
+ /* Find the ADT7463 device. */
path.type = DEVICE_PATH_I2C;
path.u.i2c.device = 0x2d;
adt7463 = find_dev_path(smbus_dev->link, &path);
if (!adt7463) {
- die("adt7463 not found\n");
+ die("ADT7463 not found\n");
}
- printk_debug("adt7463 found\n");
+ printk_debug("ADT7463 found\n");
- /* Set all fans to 'Fastest Speed Calculated by All 3 Temperature Channels Controls PWMx.' */
+ /* Set all fans to 'Fastest Speed Calculated by All 3 Temperature
+ * Channels Controls PWMx'.
+ */
result = smbus_write_byte(adt7463, 0x5c, 0xc2);
result = smbus_write_byte(adt7463, 0x5d, 0xc2);
result = smbus_write_byte(adt7463, 0x5e, 0xc2);
- /* Make sure that our fans never stop when temp falls below Tmin,
+ /* Make sure that our fans never stop when temp. falls below Tmin,
but rather keep going at minimum duty cycle (applies to automatic
- fan control mode only) */
+ fan control mode only). */
result = smbus_write_byte(adt7463, 0x62, 0xc0);
- /* Set minimum PWM duty cycle to 25%, rather than the default 50% */
+ /* Set minimum PWM duty cycle to 25%, rather than the default 50%. */
result = smbus_write_byte(adt7463, 0x64, 0x40);
result = smbus_write_byte(adt7463, 0x65, 0x40);
result = smbus_write_byte(adt7463, 0x66, 0x40);
/* Set Tmin to 55C, rather than the default 90C. Above this temperature
the fans will start blowing harder as temperature increases
- (automatic mode only) */
+ (automatic mode only). */
result = smbus_write_byte(adt7463, 0x67, 0x37);
result = smbus_write_byte(adt7463, 0x68, 0x37);
result = smbus_write_byte(adt7463, 0x69, 0x37);
- /* Set THERM limit to 70C, rather than the default 100C
+ /* Set THERM limit to 70C, rather than the default 100C.
The fans will kick in at 100% if the sensors reach this temperature,
- (only in automatic mode, but supposedly even when hardware is locked up)
- This is a failsafe measure. */
+ (only in automatic mode, but supposedly even when hardware is
+ locked up). This is a failsafe measure. */
result = smbus_write_byte(adt7463, 0x6a, 0x46);
result = smbus_write_byte(adt7463, 0x6b, 0x46);
result = smbus_write_byte(adt7463, 0x6c, 0x46);
- /* Remote temperature 1 offset (LSB == 0.25C) */
+ /* Remote temperature 1 offset (LSB == 0.25C). */
result = smbus_write_byte(adt7463, 0x70, 0x02);
- /* Remote temperature 2 offset (LSB == 0.25C) */
+
+ /* Remote temperature 2 offset (LSB == 0.25C). */
result = smbus_write_byte(adt7463, 0x72, 0x01);
- /* set TACH measurements to normal (1/second) */
+ /* Set TACH measurements to normal (1/second). */
result = smbus_write_byte(adt7463, 0x78, 0xf0);
- printk_debug("adt7463 properly initilized");
+ printk_debug("ADT7463 properly initialized");
}
static void dummy_noop(device_t dummy)
@@ -100,10 +104,10 @@
}
static struct device_operations dummy_operations = {
- .read_resources = dummy_noop,
- .set_resources = dummy_noop,
- .enable_resources = dummy_noop,
- .init = dummy_init,
+ .read_resources = dummy_noop,
+ .set_resources = dummy_noop,
+ .enable_resources = dummy_noop,
+ .init = dummy_init,
};
static unsigned int scan_root_bus(device_t root, unsigned int max)
@@ -116,15 +120,16 @@
printk_debug("scan_root_bus ok\n");
- /* The following is a little silly. We need a hook into the boot process *after*
- * the ADT7643 device has been initialized. So we create this dummy device, and we
- * put the ADT7643 s2881 specific settings in its init function, which gets called
+ /* The following is a little silly. We need a hook into the boot
+ * process *after* the ADT7643 device has been initialized. So we
+ * create this dummy device, and we put the ADT7643 S2881 specific
+ * settings in its init function, which gets called
* as the last device to be initialized.
*/
link_i = root->links;
if (link_i >= MAX_LINKS) {
- printk_debug("reached MAX_LINKS, not configuring adt7463");
+ printk_debug("Reached MAX_LINKS, not configuring ADT7463");
return max;
}
root->link[link_i].link = link_i;
@@ -142,11 +147,11 @@
}
static struct device_operations mainboard_operations = {
- .read_resources = root_dev_read_resources,
- .set_resources = root_dev_set_resources,
- .enable_resources = root_dev_enable_resources,
- .init = root_dev_init,
- .scan_bus = scan_root_bus,
+ .read_resources = root_dev_read_resources,
+ .set_resources = root_dev_set_resources,
+ .enable_resources = root_dev_enable_resources,
+ .init = root_dev_init,
+ .scan_bus = scan_root_bus,
};
static void enable_dev(struct device *dev)
@@ -157,6 +162,6 @@
#if CONFIG_CHIP_NAME == 1
struct chip_operations mainboard_tyan_s2881_ops = {
CHIP_NAME("Tyan S2881 Mainboard")
- .enable_dev = enable_dev,
+ .enable_dev = enable_dev,
};
#endif
More information about the coreboot
mailing list