[LinuxBIOS] [PATCH] Add Intel i810, i82801aa (ICH) and Asus MEW-VM support

[Uwe Hermann]

On Sat, May 26, 2007 at 04:21:03PM +0200, Peter Stuge wrote:
> > > +		drp_value = pci_read_config8(mc_dev, DRP) & 0xf; 
> 
> > > +		/* Translate it to MB and add to tomk */
> > > +		tomk = (unsigned long)(translate_i810_to_mb[drp_value]);
> 
> > > +		/* Now do the same for DIMM 1 */
> > > +		drp_value = pci_read_config8(mc_dev, DRP) >> 4;
> > 
> > Just a minor comment:
> > 
> > drp_value >>= 4
> > 
> > should work, too? No need to read the same value twice from the
> > register...
> 
> First &0xf, then >> 4 so not re-reading will always give 0.
> 
> Perhaps move the & to where it's used.

Ah, yes, thanks. I somehow missed the "& 0xf"...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070526/0f60bad4/attachment.sig>