[LinuxBIOS] ACPI license cleanup
Uwe Hermann
uwe at hermann-uwe.de
Sat Nov 3 00:02:55 CET 2007
[New thread, as it's not related to the A8V-E SE only]
On Wed, Oct 31, 2007 at 11:44:43AM +0100, Stefan Reinauer wrote:
> * Uwe Hermann <uwe at hermann-uwe.de> [071031 00:12]:
> > >>> Index: src/mainboard/asus/a8v-e_se/acpi_tables.c
> > >>> ===================================================================
> > >>> --- src/mainboard/asus/a8v-e_se/acpi_tables.c (revision 0)
> > >>> +++ src/mainboard/asus/a8v-e_se/acpi_tables.c (revision 0)
> > >>> @@ -0,0 +1,170 @@
> > >>> +/*
> > >>> + * This file is part of the LinuxBIOS project.
> > >>> + * written by Stefan Reinauer <stepan at openbios.org>
> > >>> + * ACPI FADT, FACS, and DSDT table support added by + * Nick Barker
> > >>> <nick.barker9 at btinternet.com>, and those portions
> > >>> + *
> > >>> + * Copyright (C) 2007 Rudolf Marek <r.marek at assembler.cz>
> > >> Hm, please add
> > >> Copyright (C) xxxx Stefan Reinauer <stepan at openbios.org>
> > >> Copyright (C) xxxx Nick Barker <nick.barker9 at btinternet.com>
> > >> then. I think this is not done in the original file either, and should
> > >> be fixed there, too. Listing all copyright owners explicitly is important.
> > >
> > > What about xxxxx?
> >
> > The year(s) of the copyright.
> >
> > * (C) Copyright 2004 Nick Barker
> > * (C) Copyright 2005 Stefan Reinauer
>
> Uwe.. I am listed as the original author.. how comes you suggest Nick
> has a copyright older than mine, even though the comment says he _added_
> something to my code?
No idea :)
I copied the lines from the file I thought was used as a basis,
src/mainboard/via/epia-m/acpi_tables.c, but it seems several of the
ACPI-related files have incomplete, maybe even incorrect, copyright and
license lines.
Here's the current status of all *acpi.c files in svn:
./src/southbridge/via/vt8231/vt8231_acpi.c:
No license header at all.
./src/southbridge/amd/amd8111/amd8111_acpi.c:
No license header at all.
./src/mainboard/iwill/dk8_htx/acpi_tables.c:
/*
* Island Aruma ACPI support
* written by Stefan Reinauer <stepan at openbios.org>
* (C) 2005 Stefan Reinauer
*
*
* Copyright 2005 AMD
* 2005.9 yhlu modify that to more dynamic for AMD Opteron Based MB
*/
./src/mainboard/amd/serengeti_cheetah/acpi_tables.c:
/*
* Island Aruma ACPI support
* written by Stefan Reinauer <stepan at openbios.org>
* (C) 2005 Stefan Reinauer
*
*
* Copyright 2005 AMD
* 2005.9 yhlu modify that to more dynamic for AMD Opteron Based MB
*/
./src/mainboard/via/epia-m/acpi_tables.c:
/*
* LinuxBIOS ACPI Table support
* written by Stefan Reinauer <stepan at openbios.org>
* ACPI FADT, FACS, and DSDT table support added by
* Nick Barker <nick.barker9 at btinternet.com>, and those portions
* (C) Copyright 2004 Nick Barker
* (C) Copyright 2005 Stefan Reinauer
*/
./src/mainboard/intel/xe7501devkit/acpi_tables.c:
/*
* Ported to Intel XE7501DEVKIT from Agami Aruma
* written by Stefan Reinauer <stepan at openbios.org>
* (C) 2005 Stefan Reinauer
* (C) 2005 Digital Design Corporation
*/
./src/mainboard/agami/aruma/acpi_tables.c:
/*
* Agami Aruma ACPI support
*
* Copyright 2005 Stefan Reinauer
* Copyright 2005 AMD
*
* written by Stefan Reinauer <stepan at openbios.org>
* 2005.9 yhlu modify that to more dynamic for AMD Opteron Based MB
*/
./src/mainboard/agami/aruma/acpi_tables_static.c:
/*
* Agami Aruma ACPI support
*
* written by Stefan Reinauer <stepan at coresystems.de>
* (C) 2005 Stefan Reinauer
* (C) 2007 coresystems GmbH
*/
./src/northbridge/amd/amdk8/amdk8_acpi.c:
/*============================================================================
Copyright 2005 ADVANCED MICRO DEVICES, INC. All Rights Reserved.
This software and any related documentation (the "Materials") are the
confidential proprietary information of AMD. Unless otherwise provided in a
software agreement specifically licensing the Materials, the Materials are
provided in confidence and may not be distributed, modified, or reproduced in
whole or in part by any means.
LIMITATION OF LIABILITY: THE MATERIALS ARE PROVIDED "AS IS" WITHOUT ANY
EXPRESS OR IMPLIED WARRANTY OF ANY KIND, INCLUDING BUT NOT LIMITED TO
WARRANTIES OF MERCHANTABILITY, NONINFRINGEMENT, TITLE, FITNESS FOR ANY
PARTICULAR PURPOSE, OR WARRANTIES ARISING FROM CONDUCT, COURSE OF DEALING, OR
USAGE OF TRADE. IN NO EVENT SHALL AMD OR ITS LICENSORS BE LIABLE FOR ANY
DAMAGES WHATSOEVER (INCLUDING, WITHOUT LIMITATION, DAMAGES FOR LOSS OF PROFITS,
BUSINESS INTERRUPTION, OR LOSS OF INFORMATION) ARISING OUT OF THE USE OF OR
INABILITY TO USE THE MATERIALS, EVEN IF AMD HAS BEEN ADVISED OF THE
POSSIBILITY OF SUCH DAMAGES. BECAUSE SOME JURISDICTIONS PROHIBIT THE EXCLUSION
OR LIMITATION OF LIABILITY FOR CONSEQUENTIAL OR INCIDENTAL DAMAGES, THE ABOVE
LIMITATION MAY NOT APPLY TO YOU.
AMD does not assume any responsibility for any errors which may appear in the
Materials nor any responsibility to support or update the Materials. AMD
retains the right to modify the Materials at any time, without notice, and is
not obligated to provide such modified Materials to you.
NO SUPPORT OBLIGATION: AMD is not obligated to furnish, support, or make any
further information, software, technical information, know-how, or show-how
available to you.
U.S. GOVERNMENT RESTRICTED RIGHTS: The Materials are provided with "RESTRICTED
RIGHTS." Use, duplication, or disclosure by the Government is subject to the
restrictions as set forth in FAR 52.227-14 and DFAR 252.227-7013, et seq., or
its successor. Use of the Materials by the Government constitutes
acknowledgement of AMD's proprietary rights in them.
============================================================================*/
// 2005.9 serengeti support
// by yhlu
//
/*
* 2005.9 yhlu add madt lapic creat dynamically and SRAT related
*/
./src/arch/i386/boot/acpi.c:
/*
* LinuxBIOS ACPI Table support
* written by Stefan Reinauer <stepan at openbios.org>
* (C) 2004 SUSE LINUX AG
* (C) 2005 Stefan Reinauer
*
* ACPI FADT, FACS, and DSDT table support added by
* Nick Barker <nick.barker9 at btinternet.com>, and those portions
* (C) Copyright 2004 Nick Barker
*
* Copyright 2005 ADVANCED MICRO DEVICES, INC. All Rights Reserved.
* 2005.9 yhlu add SRAT table generation
*/
I have only looked at files with "acpi" in the name so far. Other
relevant files might also need works, e.g. *fadt* etc.
> I wrote the ACPI code in 2003, originally for K8. This code is derived
> from it.
>
> Which is why this is (C) 2003 SUSE Linux AG
OK, so if all of the above is based on that 2003 SUSE code, all of the above
files (and likely some other ACPI-related ones?) need some serious fixing.
Please let me know _how_ they are to be fixed and I can provide patches (or
you do the work and post patches, either is fine).
All of the files share (at least) one problem, the missing GPL header (GPLv2,
I assume?), which we should add. Other problems are the seemingly
incorrect/incomplete (C) lines.
Thanks, Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20071103/50a57f38/attachment.sig>
More information about the coreboot
mailing list